Skip to content

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 2, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per https://stackoverflow.com/questions/629667/why-remove-unused-using-directives-in-c, clean up Dynamo Solution and remove all the usings which are not needed.

  1. Cleaner codebase ⚡️
  2. System using remain above custom usings in all files
  3. Coding Standards updated

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @alfarok @ColinDayOrg @reddyashish @scottmitchell

FYIs

@mjkkirschner
Copy link
Member

@QilongTang LGTM

@QilongTang
Copy link
Contributor Author

@mjkkirschner @alfarok @ColinDayOrg @scottmitchell @reddyashish Coding standards updated, merging

@QilongTang QilongTang merged commit 8afcde0 into master Jan 2, 2019
reddyashish added a commit that referenced this pull request Jan 2, 2019
@QilongTang QilongTang deleted the RemoveAndSortUsings branch January 2, 2019 16:22
QilongTang added a commit that referenced this pull request Jan 2, 2019
reddyashish added a commit that referenced this pull request Jan 2, 2019
* Revert "Remove and Sort Usings (#9352)"

This reverts commit 8afcde0.

* Revert "Bump Version Number and RevisionNumber time baseline (#9336)"

This reverts commit 24c4e77.

* Revert "Heterogeneous list update gives infinite loop (#9334)"

This reverts commit 67a19a7.
QilongTang added a commit that referenced this pull request Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants