libG copy steps should have the same behavior as before. #9311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
@QilongTang noticed a change in the libG folder names copied the bin directory.
I'm not a fan of the libG folders in extern being
LibG_and those in bin beinglibG_- but I think this is the least risky change at this point.Normally this should not be a problem on standard windows, but it might be on mono, mac, linux platforms.
This PR just reverts the copy steps to their previous behavior.
Some alternatives:
var libGFolderName = string.Format("Libg_{0}_{1}_{2}", major, minor, build);instead of the lowercase libG.Looking for some feedback/thoughts.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
@aparajit-pratap
FYIs
@smangarole