Skip to content

[jit] Renamed prim::Concat as prim::VarConcat#61498

Closed
navahgar wants to merge 5 commits intogh/navahgar/34/basefrom
gh/navahgar/34/head
Closed

[jit] Renamed prim::Concat as prim::VarConcat#61498
navahgar wants to merge 5 commits intogh/navahgar/34/basefrom
gh/navahgar/34/head

Conversation

@navahgar
Copy link
Copy Markdown
Contributor

@navahgar navahgar commented Jul 10, 2021 •
edited
Loading

This was referenced Jul 10, 2021
Closed
Closed
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 10, 2021
@navahgar navahgar mentioned this pull request Jul 10, 2021
Closed
@navahgar navahgar mentioned this pull request Jul 10, 2021
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 10, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 60cf0b9 (more details on the Dr. CI page and at hud.pytorch.org/pr/61498):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 20 06:02:24 The PR is introducing backward ...m to confirm whether this change is wanted or not. 
Jul 20 06:02:24 processing existing schema:  alltoall_base(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor _1, Tensor _2, int[] _3, int[] _4) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jul 20 06:02:24 processing existing schema:  alltoall(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, Tensor[] _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jul 20 06:02:24 processing existing schema:  send(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jul 20 06:02:24 processing existing schema:  recv(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jul 20 06:02:24 processing existing schema:  recv_anysource(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jul 20 06:02:24 processing existing schema:  barrier(__torch__.torch.classes.dist_c10d.ProcessGroup _0) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jul 20 06:02:24 processing existing schema:  __init__(__torch__.torch.classes.dist_c10d.frontend _0) -> (NoneType _0)
Jul 20 06:02:24 processing existing schema:  new_process_group_helper(__torch__.torch.classes.dist_c10d.frontend _0, int _1, int _2, int[] _3, str _4, __torch__.torch.classes.dist_c10d.Store _5, str? _6, int _7) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
Jul 20 06:02:24 processing existing schema:  get_process_group_by_name(__torch__.torch.classes.dist_c10d.frontend _0, str _1) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
Jul 20 06:02:24 processing existing schema:  get_name_of_process_group(__torch__.torch.classes.dist_c10d.frontend _0, __torch__.torch.classes.dist_c10d.ProcessGroup _1) -> (str _0)
Jul 20 06:02:24 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Jul 20 06:02:24 
Jul 20 06:02:24 Broken ops: [
Jul 20 06:02:24 	prim::Concat(...) -> (Tensor)
Jul 20 06:02:24 ]
Jul 20 06:02:24 + cleanup
Jul 20 06:02:24 + retcode=1
Jul 20 06:02:24 + set +x
Jul 20 06:02:24 =================== sccache compilation log ===================
Jul 20 06:02:24 =========== If your build fails, please take a look at the log above for possible reasons ===========
Jul 20 06:02:24 Compile requests                      0

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

navahgar added a commit that referenced this pull request Jul 10, 2021
@navahgar
[jit] Renamed prim::Concat as prim::ConstantConcat
a4660a9 
ghstack-source-id: a04c89f
Pull Request resolved: #61498
@navahgar navahgar requested a review from eellison July 10, 2021 00:38
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 10, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar added a commit that referenced this pull request Jul 19, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
e100fbd 
ghstack-source-id: 08c2574
Pull Request resolved: #61498
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 19, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@navahgar navahgar changed the title [jit] Renamed prim::Concat as prim::ConstantConcat [jit] Renamed prim::Concat as prim::VarConcat Jul 19, 2021
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 19, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar added a commit that referenced this pull request Jul 19, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
32150cb 
ghstack-source-id: 09c4fd5
Pull Request resolved: #61498
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 19, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar added a commit that referenced this pull request Jul 20, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
946175f 
ghstack-source-id: 5928f48
Pull Request resolved: #61498
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 20, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2021

@navahgar merged this pull request in db11619.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2021

This pull request has been reverted by 33db828.

@navahgar navahgar mentioned this pull request Jul 21, 2021
Closed
navahgar added a commit that referenced this pull request Jul 22, 2021
@navahgar
Update base for Update on "[jit] Renamed prim::Concat as prim::VarCon…
8836c7b 
…cat"


Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 22, 2021
@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
afabf60 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 23, 2021
@navahgar
Update base for Update on "[jit] Renamed prim::Concat as prim::VarCon…
bb20664 
…cat"


Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 23, 2021
@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
6f8c2e4 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 23, 2021
@navahgar
Update base for Update on "[jit] Renamed prim::Concat as prim::VarCon…
de1f4bc 
…cat"


Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 23, 2021
@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
9d6ad75 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot deleted the gh/navahgar/34/head branch July 24, 2021 14:17
navahgar added a commit that referenced this pull request Jul 27, 2021
@navahgar
Update base for Update on "[jit] Renamed prim::Concat as prim::VarCon…
ca1e7f9 
…cat"


Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 27, 2021
@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
eeeadfe 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jul 29, 2021
@navahgar @facebook-github-bot
[jit] Renamed prim::Concat as prim::VarConcat (#61983)
7b6d569 
Summary:
Pull Request resolved: #61983

Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Test Plan: Imported from OSS

Reviewed By: eellison

Differential Revision: D29828830

Pulled By: navahgar

fbshipit-source-id: 947a7b1622ff6e3e575c051b8f34a789e105bcee
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@navahgar @facebook-github-bot
[jit] Renamed prim::Concat as prim::VarConcat (pytorch#61498)
7dcac9a 
Summary: Pull Request resolved: pytorch#61498

Test Plan: Imported from OSS

Reviewed By: eellison

Differential Revision: D29647586

Pulled By: navahgar

fbshipit-source-id: cdd34ea5a3c986350a813be17e7d428844ea4cbf
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@navahgar @facebook-github-bot
[jit] Renamed prim::Concat as prim::VarConcat (pytorch#61983)
35b20c9 
Summary:
Pull Request resolved: pytorch#61983

Trial pytorch#2. The previous PR (pytorch#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Test Plan: Imported from OSS

Reviewed By: eellison

Differential Revision: D29828830

Pulled By: navahgar

fbshipit-source-id: 947a7b1622ff6e3e575c051b8f34a789e105bcee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@navahgar @facebook-github-bot @eellison