Skip to content

[jit] Renamed prim::Concat as prim::VarConcat#61983

Closed
navahgar wants to merge 5 commits intogh/navahgar/39/basefrom
gh/navahgar/39/head
Closed

[jit] Renamed prim::Concat as prim::VarConcat#61983
navahgar wants to merge 5 commits intogh/navahgar/39/basefrom
gh/navahgar/39/head

Conversation

@navahgar
Copy link
Copy Markdown
Contributor

@navahgar navahgar commented Jul 21, 2021 •
edited
Loading

Stack from ghstack:

Trial #2. The previous PR (#61498) was reverted because this caused a failure in pytorch_linux_backward_compatibility_check_test. Fixed that now by adding to the exception list in check_backward_compatibility.py.

Differential Revision: D29828830

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Jul 21, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit eeeadfe (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jul 27 20:14:14 *** WARNING: renaming "_hashlib...open shared object file: No such file or directory 
Jul 27 20:14:14 [ 51%] Building C object confu-deps/XNNPACK/CMakeFiles/XNNPACK.dir/src/f32-gemm/gen/4x16s4-minmax-fma3-broadcast.c.o
Jul 27 20:14:14 building '_hashlib' extension
Jul 27 20:14:14 gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -fPIC -fPIC -I/var/lib/jenkins/workspace/torch/csrc/deploy/interpreter/cpython/include -I./Include -I/var/lib/jenkins/workspace/torch/csrc/deploy/interpreter/cpython/include -I. -I/usr/include/x86_64-linux-gnu -I/usr/local/include -I/var/lib/jenkins/workspace/build/torch/csrc/deploy/interpreter/cpython/src/cpython/Include -I/var/lib/jenkins/workspace/build/torch/csrc/deploy/interpreter/cpython/src/cpython -c /var/lib/jenkins/workspace/build/torch/csrc/deploy/interpreter/cpython/src/cpython/Modules/_hashopenssl.c -o build/temp.linux-x86_64-3.8/var/lib/jenkins/workspace/build/torch/csrc/deploy/interpreter/cpython/src/cpython/Modules/_hashopenssl.o
Jul 27 20:14:14 [ 51%] Building C object confu-deps/XNNPACK/CMakeFiles/XNNPACK.dir/src/f32-gemm/gen/5x8-minmax-fma3-broadcast.c.o
Jul 27 20:14:14 [ 51%] Building C object confu-deps/XNNPACK/CMakeFiles/XNNPACK.dir/src/f32-gemm/gen/5x16-minmax-fma3-broadcast.c.o
Jul 27 20:14:14 gcc -pthread -shared build/temp.linux-x86_64-3.8/var/lib/jenkins/workspace/build/torch/csrc/deploy/interpreter/cpython/src/cpython/Modules/_hashopenssl.o -L/var/lib/jenkins/workspace/torch/csrc/deploy/interpreter/cpython/lib -L/var/lib/jenkins/workspace/torch/csrc/deploy/interpreter/cpython/lib -L/usr/lib/x86_64-linux-gnu -L/usr/local/lib -lssl -lcrypto -o build/lib.linux-x86_64-3.8/_hashlib.cpython-38-x86_64-linux-gnu.so
Jul 27 20:14:14 [ 51%] Building C object confu-deps/XNNPACK/CMakeFiles/XNNPACK.dir/src/f32-gemm/gen/5x16s4-minmax-fma3-broadcast.c.o
Jul 27 20:14:14 [ 51%] Building C object confu-deps/XNNPACK/CMakeFiles/XNNPACK.dir/src/f32-gemm/gen/6x8-minmax-fma3-broadcast.c.o
Jul 27 20:14:14 [ 51%] Building C object confu-deps/XNNPACK/CMakeFiles/XNNPACK.dir/src/f32-gemm/gen/7x8-minmax-fma3-broadcast.c.o
Jul 27 20:14:14 *** WARNING: renaming "_ssl" since importing it failed: libssl.so.1.1: cannot open shared object file: No such file or directory
Jul 27 20:14:14 *** WARNING: renaming "_hashlib" since importing it failed: libcrypto.so.1.1: cannot open shared object file: No such file or directory
Jul 27 20:14:14 
Jul 27 20:14:14 The following modules found by detect_modules() in setup.py, have been
Jul 27 20:14:14 built by the Makefile instead, as configured by the Setup files:
Jul 27 20:14:14 _abc                  atexit                pwd                
Jul 27 20:14:14 time                                                           
Jul 27 20:14:14 
Jul 27 20:14:14 
Jul 27 20:14:14 Following modules built successfully but were removed because they could not be imported:
Jul 27 20:14:14 _hashlib              _ssl                                     
Jul 27 20:14:14

1 job timed out:

  • pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_build
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

navahgar added a commit that referenced this pull request Jul 21, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
5d56575 
ghstack-source-id: 0e3775e
Pull Request resolved: #61983
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 21, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@navahgar navahgar requested a review from eellison July 21, 2021 20:45
eellison
eellison approved these changes Jul 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
afabf60 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 22, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
c0d717c 
ghstack-source-id: e663394
Pull Request resolved: #61983
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 22, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
6f8c2e4 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 23, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
0867907 
ghstack-source-id: 0664655
Pull Request resolved: #61983
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 23, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
9d6ad75 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 23, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
7de089e 
ghstack-source-id: 2810b12
Pull Request resolved: #61983
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 23, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@navahgar
Update on "[jit] Renamed prim::Concat as prim::VarConcat"
eeeadfe 
Trial #2. The previous PR (#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Differential Revision: [D29828830](https://our.internmc.facebook.com/intern/diff/D29828830)

[ghstack-poisoned]
navahgar added a commit that referenced this pull request Jul 27, 2021
@navahgar
[jit] Renamed prim::Concat as prim::VarConcat
b462ac1 
ghstack-source-id: 3e27f71
Pull Request resolved: #61983
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 27, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 29, 2021

@navahgar merged this pull request in 7b6d569.

@facebook-github-bot facebook-github-bot deleted the gh/navahgar/39/head branch August 2, 2021 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@navahgar @facebook-github-bot
[jit] Renamed prim::Concat as prim::VarConcat (pytorch#61983)
35b20c9 
Summary:
Pull Request resolved: pytorch#61983

Trial pytorch#2. The previous PR (pytorch#61498) was reverted because this caused a failure in `pytorch_linux_backward_compatibility_check_test`. Fixed that now by adding to the exception list in `check_backward_compatibility.py`.

Test Plan: Imported from OSS

Reviewed By: eellison

Differential Revision: D29828830

Pulled By: navahgar

fbshipit-source-id: 947a7b1622ff6e3e575c051b8f34a789e105bcee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@navahgar @facebook-github-bot @eellison