[jit] Removed a local function to check for dominators and used the one added to Node class#60909

Closed

navahgar wants to merge 6 commits intogh/navahgar/28/basefrom

gh/navahgar/28/head

Contributor

navahgar commented Jun 28, 2021 •

edited

Loading

Stack from ghstack:

[jit] Renamed prim::Concat as prim::VarConcat #61498
[jit] Removed a local function to check for dominators and used the one added to Node class #60909
[jit] Updated the concat common inputs elimination pass to use the variadic cat op instead of aten::cat #60908
[jit] Added an API to remove list mutations and replace with variadic cat until fixed point #60776
[jit] Added special handling for prim::ListConstruct while checking for may alias inputs #60775
[jit] Handled cases when input list to cat is mutated after cat using AliasDb #60774

Differential Revision: D29441864


          [jit] Removed a local function to check for dominators and used the o…

6b9012d

…ne added to Node class

[ghstack-poisoned]

This was referenced Jun 28, 2021

[jit] Handled cases when input list to cat is mutated after cat using AliasDb #60774

Closed

[jit] Added special handling for prim::ListConstruct while checking for may alias inputs #60775

Closed

[jit] Added an API to remove list mutations and replace with variadic cat until fixed point #60776

Closed

[jit] Updated the concat common inputs elimination pass to use the variadic cat op instead of aten::cat #60908

Closed

facebook-github-bot added oncall: jit cla signed labels

Contributor

facebook-github-bot commented Jun 28, 2021 •

edited

Loading

💊 CI failures summary and remediations

As of commit 14b3ffb (more details on the Dr. CI page and at hud.pytorch.org/pr/60909):

1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job	Step	Action
^{Linux CI (pytorch-linux-bionic-py3.8-gcc9-coverage) / render_test_results (default)}	^{Checkout PyTorch}	🔁 rerun

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

navahgar added a commit that referenced this pull request


          [jit] Removed a local function to check for dominators and used the o…

c41474a

…ne added to Node class

ghstack-source-id: b0a5036
Pull Request resolved: #60909

Contributor Author

navahgar commented Jun 28, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar requested a review from eellison

June 29, 2021 00:01

eellison approved these changes

View reviewed changes


          Update on "[jit] Removed a local function to check for dominators and…

28dd439

… used the one added to Node class"

Differential Revision: [D29441864](https://our.internmc.facebook.com/intern/diff/D29441864)

[ghstack-poisoned]

navahgar added a commit that referenced this pull request


          [jit] Removed a local function to check for dominators and used the o…

f0f33e6

…ne added to Node class

ghstack-source-id: fdc6b71
Pull Request resolved: #60909

Contributor Author

navahgar commented Jul 9, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar mentioned this pull request

[jit] Renamed prim::Concat as prim::VarConcat #61498

Closed


          Update on "[jit] Removed a local function to check for dominators and…

898effb

… used the one added to Node class"

Differential Revision: [D29441864](https://our.internmc.facebook.com/intern/diff/D29441864)

[ghstack-poisoned]

Contributor Author

navahgar commented Jul 19, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[jit] Removed a local function to check for dominators and…

29c7e70

… used the one added to Node class"

Differential Revision: [D29441864](https://our.internmc.facebook.com/intern/diff/D29441864)

[ghstack-poisoned]

Contributor Author

navahgar commented Jul 19, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[jit] Removed a local function to check for dominators and…

aab37dc

… used the one added to Node class"

Differential Revision: [D29441864](https://our.internmc.facebook.com/intern/diff/D29441864)

[ghstack-poisoned]

Contributor Author

navahgar commented Jul 19, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[jit] Removed a local function to check for dominators and…

14b3ffb

… used the one added to Node class"

Differential Revision: [D29441864](https://our.internmc.facebook.com/intern/diff/D29441864)

[ghstack-poisoned]

Contributor Author

navahgar commented Jul 20, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot closed this in

7fbdc86

Contributor

facebook-github-bot commented Jul 21, 2021

@navahgar merged this pull request in 7fbdc86.

facebook-github-bot added the Merged label

facebook-github-bot deleted the gh/navahgar/28/head branch

July 24, 2021 14:17

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request


          [jit] Removed a local function to check for dominators and used the o…

a8dab49

…ne added to Node class (pytorch#60909)

Summary: Pull Request resolved: pytorch#60909

Test Plan: Imported from OSS

Reviewed By: eellison

Differential Revision: D29441864

Pulled By: navahgar

fbshipit-source-id: 362bd462fa70256dd1f8b05756a76da0cb3d4b76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit