[jit] Added an API to remove list mutations and replace with variadic cat until fixed point#60776
[jit] Added an API to remove list mutations and replace with variadic cat until fixed point#60776navahgar wants to merge 7 commits intogh/navahgar/26/basefrom
Conversation
… cat until fixed point [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 1f4ffc0 (more details on the Dr. CI page and at hud.pytorch.org/pr/60776): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…th variadic cat until fixed point" Differential Revision: [D29406099](https://our.internmc.facebook.com/intern/diff/D29406099) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…th variadic cat until fixed point" Differential Revision: [D29406099](https://our.internmc.facebook.com/intern/diff/D29406099) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…th variadic cat until fixed point" Differential Revision: [D29406099](https://our.internmc.facebook.com/intern/diff/D29406099) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| return changed; | ||
| } | ||
|
|
||
| bool RemoveListMutationAndUseVariadicCat(const std::shared_ptr<Graph>& graph) { |
There was a problem hiding this comment.
Looks good but as discussed offline eventually we would like to make this one pass instead of running each back and forth
There was a problem hiding this comment.
Sure. That requires refactoring some of the code to work on nodes instead of graphs on the whole. Will do that as a follow-up.
…th variadic cat until fixed point" Differential Revision: [D29406099](https://our.internmc.facebook.com/intern/diff/D29406099) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…th variadic cat until fixed point" Differential Revision: [D29406099](https://our.internmc.facebook.com/intern/diff/D29406099) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…th variadic cat until fixed point" Differential Revision: [D29406099](https://our.internmc.facebook.com/intern/diff/D29406099) [ghstack-poisoned]
|
@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… cat until fixed point (pytorch#60776) Summary: Pull Request resolved: pytorch#60776 Test Plan: Imported from OSS Reviewed By: eellison Differential Revision: D29406099 Pulled By: navahgar fbshipit-source-id: e2e69eb6ebff3bc6e25d80f46ce118e52f557fb6
Stack from ghstack:
Differential Revision: D29406099