Skip to content

[jit] Updated the concat common inputs elimination pass to use the variadic cat op instead of aten::cat#60908

Closed
navahgar wants to merge 6 commits intogh/navahgar/27/basefrom
gh/navahgar/27/head
Closed

[jit] Updated the concat common inputs elimination pass to use the variadic cat op instead of aten::cat#60908
navahgar wants to merge 6 commits intogh/navahgar/27/basefrom
gh/navahgar/27/head

Conversation

…riadic cat op instead of aten::cat

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 28, 2021

💊 CI failures summary and remediations

As of commit 3e00623 (more details on the Dr. CI page and at hud.pytorch.org/pr/60908):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@navahgar
Copy link
Copy Markdown
Contributor Author

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@navahgar navahgar requested a review from eellison June 28, 2021 23:56
Copy link
Copy Markdown
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt look too closely but changes should be pretty much mechanical

… use the variadic cat op instead of aten::cat"

Differential Revision: [D29441865](https://our.internmc.facebook.com/intern/diff/D29441865)

[ghstack-poisoned]
@navahgar
Copy link
Copy Markdown
Contributor Author

navahgar commented Jul 9, 2021

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… use the variadic cat op instead of aten::cat"

Differential Revision: [D29441865](https://our.internmc.facebook.com/intern/diff/D29441865)

[ghstack-poisoned]
@navahgar
Copy link
Copy Markdown
Contributor Author

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… use the variadic cat op instead of aten::cat"

Differential Revision: [D29441865](https://our.internmc.facebook.com/intern/diff/D29441865)

[ghstack-poisoned]
@navahgar
Copy link
Copy Markdown
Contributor Author

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… use the variadic cat op instead of aten::cat"

Differential Revision: [D29441865](https://our.internmc.facebook.com/intern/diff/D29441865)

[ghstack-poisoned]
@navahgar
Copy link
Copy Markdown
Contributor Author

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… use the variadic cat op instead of aten::cat"

Differential Revision: [D29441865](https://our.internmc.facebook.com/intern/diff/D29441865)

[ghstack-poisoned]
@navahgar
Copy link
Copy Markdown
Contributor Author

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@navahgar merged this pull request in 429908e.

@facebook-github-bot facebook-github-bot deleted the gh/navahgar/27/head branch July 24, 2021 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
…riadic cat op instead of aten::cat (pytorch#60908)

Summary: Pull Request resolved: pytorch#60908

Test Plan: Imported from OSS

Reviewed By: eellison

Differential Revision: D29441865

Pulled By: navahgar

fbshipit-source-id: 2ab08168102eff1f43667ca418bdd94bb2df562a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants