Bump Ubuntu/Python versions in ECR GC Docker image#58309
Closed
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:ecr-gc-python-version
Closed
Bump Ubuntu/Python versions in ECR GC Docker image#58309samestep wants to merge 1 commit intopytorch:masterfrom samestep:ecr-gc-python-version
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:ecr-gc-python-version
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 7cc5cec (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
approved these changes
May 14, 2021
Contributor
|
I did a quick search |
Contributor
Author
@zhouzhuojie yeah that sounds good if you want to open a PR to do that! |
walterddr
approved these changes
May 14, 2021
Contributor
Contributor
we can just delete it #58333 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 15, 2021
Summary: A followup to #58309, to fix the broken docker_for_ecr_gc_build_job: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322672/workflows/4877ddfe-eee1-4116-91ae-6ee9dd3a97ad/jobs/13486207 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322710/workflows/8d33afb6-7b85-48c7-94fd-ac9176f4a16e/jobs/13488388 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322759/workflows/b480989a-b39e-48f7-929d-66f1bdc50c89/jobs/13490919 Pull Request resolved: #58334 Test Plan: Before this PR, this fails: ``` cd .circleci/ecr_gc_docker && docker build . ``` After this PR, it succeeds. Reviewed By: zhouzhuojie Differential Revision: D28457290 Pulled By: samestep fbshipit-source-id: d8d8c8759412d9d7876d5908768ee5cb7261132d
facebook-github-bot
pushed a commit
that referenced
this pull request
May 17, 2021
Summary: Related to the effort of upgrade ubuntu base images #58309, this PR removes the unused tools/docker/Dockerfile_runtime It was introduced in #1619, #1732 - No code references in pytorch github org https://github.com/search?q=org%3Apytorch+Dockerfile_runtime&type=code - Runtime images are available https://hub.docker.com/r/pytorch/pytorch/tags?page=1&ordering=last_updated&name=runtime (~2GB image size) One less thing to maintain... Pull Request resolved: #58333 Reviewed By: samestep Differential Revision: D28457139 Pulled By: zhouzhuojie fbshipit-source-id: 3c7034c52eb71463ac284dc48f0f9bbbf3af1312
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Should fix the ECR GC jobs that broke as a result of pytorch#58275; examples: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13480923 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473074 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473077 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473073 See also pytorch#58308. Pull Request resolved: pytorch#58309 Reviewed By: malfet, seemethere Differential Revision: D28447014 Pulled By: samestep fbshipit-source-id: db857154a94482f4da1db8d74c383527d1b14b49
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: A followup to pytorch#58309, to fix the broken docker_for_ecr_gc_build_job: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322672/workflows/4877ddfe-eee1-4116-91ae-6ee9dd3a97ad/jobs/13486207 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322710/workflows/8d33afb6-7b85-48c7-94fd-ac9176f4a16e/jobs/13488388 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322759/workflows/b480989a-b39e-48f7-929d-66f1bdc50c89/jobs/13490919 Pull Request resolved: pytorch#58334 Test Plan: Before this PR, this fails: ``` cd .circleci/ecr_gc_docker && docker build . ``` After this PR, it succeeds. Reviewed By: zhouzhuojie Differential Revision: D28457290 Pulled By: samestep fbshipit-source-id: d8d8c8759412d9d7876d5908768ee5cb7261132d
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Related to the effort of upgrade ubuntu base images pytorch#58309, this PR removes the unused tools/docker/Dockerfile_runtime It was introduced in pytorch#1619, pytorch#1732 - No code references in pytorch github org https://github.com/search?q=org%3Apytorch+Dockerfile_runtime&type=code - Runtime images are available https://hub.docker.com/r/pytorch/pytorch/tags?page=1&ordering=last_updated&name=runtime (~2GB image size) One less thing to maintain... Pull Request resolved: pytorch#58333 Reviewed By: samestep Differential Revision: D28457139 Pulled By: zhouzhuojie fbshipit-source-id: 3c7034c52eb71463ac284dc48f0f9bbbf3af1312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the ECR GC jobs that broke as a result of #58275; examples:
See also #58308.