Use pip3 instead of pip when building ECR GC image#58334
Closed
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:ecg-gc-pip3
Closed
Use pip3 instead of pip when building ECR GC image#58334samestep wants to merge 1 commit intopytorch:masterfrom samestep:ecg-gc-pip3
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:ecg-gc-pip3
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 5aaa470 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zhouzhuojie
approved these changes
May 14, 2021
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: A followup to pytorch#58309, to fix the broken docker_for_ecr_gc_build_job: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322672/workflows/4877ddfe-eee1-4116-91ae-6ee9dd3a97ad/jobs/13486207 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322710/workflows/8d33afb6-7b85-48c7-94fd-ac9176f4a16e/jobs/13488388 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322759/workflows/b480989a-b39e-48f7-929d-66f1bdc50c89/jobs/13490919 Pull Request resolved: pytorch#58334 Test Plan: Before this PR, this fails: ``` cd .circleci/ecr_gc_docker && docker build . ``` After this PR, it succeeds. Reviewed By: zhouzhuojie Differential Revision: D28457290 Pulled By: samestep fbshipit-source-id: d8d8c8759412d9d7876d5908768ee5cb7261132d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup to #58309, to fix the broken docker_for_ecr_gc_build_job:
Test plan:
Before this PR, this fails:
After this PR, it succeeds.