Remove unused Dockerfile_runtime#58333
Closed
zhouzhuojie wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 673dea5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@zhouzhuojie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
approved these changes
May 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #58333 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 1992 1992
Lines 199897 199897
=======================================
+ Hits 152866 152873 +7
+ Misses 47031 47024 -7 |
malfet
approved these changes
May 17, 2021
Contributor
|
@zhouzhuojie merged this pull request in bef0e07. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Related to the effort of upgrade ubuntu base images pytorch#58309, this PR removes the unused tools/docker/Dockerfile_runtime It was introduced in pytorch#1619, pytorch#1732 - No code references in pytorch github org https://github.com/search?q=org%3Apytorch+Dockerfile_runtime&type=code - Runtime images are available https://hub.docker.com/r/pytorch/pytorch/tags?page=1&ordering=last_updated&name=runtime (~2GB image size) One less thing to maintain... Pull Request resolved: pytorch#58333 Reviewed By: samestep Differential Revision: D28457139 Pulled By: zhouzhuojie fbshipit-source-id: 3c7034c52eb71463ac284dc48f0f9bbbf3af1312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the effort of upgrade ubuntu base images #58309, this PR removes the unused tools/docker/Dockerfile_runtime
It was introduced in #1619, #1732
One less thing to maintain...