[CircleCI] s/ubuntu-1604:202007-01/ubuntu-2004:202104-01/#58308
Closed
malfet wants to merge 5 commits intopytorch:masterfrom
Closed
[CircleCI] s/ubuntu-1604:202007-01/ubuntu-2004:202104-01/#58308malfet wants to merge 5 commits intopytorch:masterfrom
malfet wants to merge 5 commits intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit b38ac9b (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2021
Summary: Should fix the ECR GC jobs that broke as a result of #58275; examples: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13480923 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473074 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473077 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473073 See also #58308. Pull Request resolved: #58309 Reviewed By: malfet, seemethere Differential Revision: D28447014 Pulled By: samestep fbshipit-source-id: db857154a94482f4da1db8d74c383527d1b14b49
7cc4e9d to
6b38e66
Compare
walterddr
approved these changes
May 14, 2021
walterddr
reviewed
May 14, 2021
Contributor
walterddr
left a comment
There was a problem hiding this comment.
seems like pip install is failing.
Contributor
Author
|
@walterddr yeah, because there are no unversioned pip in newer distros, only pip2 and pip3 |
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Should fix the ECR GC jobs that broke as a result of pytorch#58275; examples: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13480923 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473074 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473077 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473073 See also pytorch#58308. Pull Request resolved: pytorch#58309 Reviewed By: malfet, seemethere Differential Revision: D28447014 Pulled By: samestep fbshipit-source-id: db857154a94482f4da1db8d74c383527d1b14b49
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
) Summary: Switch to latest ubuntu supported by CircleCI, according to https://circleci.com/docs/2.0/configuration-reference/#machine Also upgrade awscli from 1.x to 2.x, which requires replacing aws ecr get-login with awc ecr get-login-password, per https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html#cliv2-migration-ecr-get-login Pull Request resolved: pytorch#58308 Reviewed By: walterddr Differential Revision: D28446659 Pulled By: malfet fbshipit-source-id: 260f795dce83b3d191d8e3fa629c77c1b9fae36c
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Nov 2, 2021
Replacing `aws ecr get-login` with `awc ecr get-login-password`, per https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html#cliv2-migration-ecr-get-login Follow up after the similar change in CircleCI: pytorch#58308
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
Summary: Replacing `aws ecr get-login` with `awc ecr get-login-password`, per https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html#cliv2-migration-ecr-get-login Follow up after the similar change in CircleCI: #58308 Pull Request resolved: #67709 Reviewed By: seemethere, janeyx99 Differential Revision: D32119319 Pulled By: malfet fbshipit-source-id: 0cd0d8f4d81e9981a5f8fbf9b812a9167fd48135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to latest ubuntu supported by CircleCI, according to https://circleci.com/docs/2.0/configuration-reference/#machine
Also upgrade awscli from 1.x to 2.x, which requires replacing aws ecr get-login with awc ecr get-login-password, per https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html#cliv2-migration-ecr-get-login