[BE] [GHA] Use aws ecr get-login-password#67709
Closed
malfet wants to merge 2 commits intopytorch:masterfrom
Closed
[BE] [GHA] Use aws ecr get-login-password#67709malfet wants to merge 2 commits intopytorch:masterfrom
aws ecr get-login-password#67709malfet wants to merge 2 commits intopytorch:masterfrom
Conversation
Replacing `aws ecr get-login` with `awc ecr get-login-password`, per https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html#cliv2-migration-ecr-get-login Follow up after the similar change in CircleCI: pytorch#58308
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 78fc41a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Also, remove re-defined AWS_ALPINE_IMAGE and AWS_DEFAULT_REGION variables
1eec34b to
78fc41a
Compare
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
janeyx99
approved these changes
Nov 2, 2021
Contributor
janeyx99
left a comment
There was a problem hiding this comment.
Looks like the step is working 🎉
seemethere
approved these changes
Nov 2, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing
aws ecr get-loginwithawc ecr get-login-password, per https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html#cliv2-migration-ecr-get-loginFollow up after the similar change in CircleCI: #58308