Disallow versionless Python shebangs#58275
Closed
samestep wants to merge 2 commits intopytorch:masterfrom
samestep:lint-shebang-python-version
Closed
Disallow versionless Python shebangs#58275samestep wants to merge 2 commits intopytorch:masterfrom samestep:lint-shebang-python-version
samestep wants to merge 2 commits intopytorch:masterfrom
samestep:lint-shebang-python-version
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 7c4f7eb (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zhouzhuojie
approved these changes
May 13, 2021
Contributor
|
thanks! many places have safeguard on python2 usage, I think we are good |
janeyx99
approved these changes
May 13, 2021
Codecov Report
|
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2021
Summary: Should fix the ECR GC jobs that broke as a result of #58275; examples: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13480923 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473074 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473077 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473073 See also #58308. Pull Request resolved: #58309 Reviewed By: malfet, seemethere Differential Revision: D28447014 Pulled By: samestep fbshipit-source-id: db857154a94482f4da1db8d74c383527d1b14b49
facebook-github-bot
pushed a commit
that referenced
this pull request
May 17, 2021
Summary: This is the only line (not in `third_party`) matching the regex `^#!.*python2`, and [it is not the first line of its file](https://github.com/koalaman/shellcheck/wiki/SC1128), so it has no effect. As a followup to #58275, this PR removes that shebang to reduce confusion, so now all Python shebangs in this repo are `python3`. Pull Request resolved: #58409 Reviewed By: walterddr Differential Revision: D28478469 Pulled By: samestep fbshipit-source-id: c17684c8651e45d3fc383cbbc04a31192d10f52f
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Some machines don't have a versionless `python` on their PATH, which breaks these existing shebangs. I'm assuming that all the existing versionless `python` shebangs are meant to be `python3` and not `python2`; please let me know if my assumption was incorrect for any of these. Pull Request resolved: pytorch#58275 Test Plan: CI. Reviewed By: zhouzhuojie Differential Revision: D28428143 Pulled By: samestep fbshipit-source-id: 6562be3d12924db72a92a0207b060ef740f61ebf
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Should fix the ECR GC jobs that broke as a result of pytorch#58275; examples: - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13480923 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473074 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473077 - https://app.circleci.com/pipelines/github/pytorch/pytorch/322385/workflows/c26788cb-2147-4279-9813-224af3c01583/jobs/13473073 See also pytorch#58308. Pull Request resolved: pytorch#58309 Reviewed By: malfet, seemethere Differential Revision: D28447014 Pulled By: samestep fbshipit-source-id: db857154a94482f4da1db8d74c383527d1b14b49
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This is the only line (not in `third_party`) matching the regex `^#!.*python2`, and [it is not the first line of its file](https://github.com/koalaman/shellcheck/wiki/SC1128), so it has no effect. As a followup to pytorch#58275, this PR removes that shebang to reduce confusion, so now all Python shebangs in this repo are `python3`. Pull Request resolved: pytorch#58409 Reviewed By: walterddr Differential Revision: D28478469 Pulled By: samestep fbshipit-source-id: c17684c8651e45d3fc383cbbc04a31192d10f52f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some machines don't have a versionless
pythonon their PATH, which breaks these existing shebangs.I'm assuming that all the existing versionless
pythonshebangs are meant to bepython3and notpython2; please let me know if my assumption was incorrect for any of these.Test plan:
CI.