Remove unused python2 shebang#58409
Closed
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:remove-unused-python2-shebang
Closed
Remove unused python2 shebang#58409samestep wants to merge 1 commit intopytorch:masterfrom samestep:remove-unused-python2-shebang
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:remove-unused-python2-shebang
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit df36ad1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
approved these changes
May 17, 2021
seemethere
approved these changes
May 17, 2021
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This is the only line (not in `third_party`) matching the regex `^#!.*python2`, and [it is not the first line of its file](https://github.com/koalaman/shellcheck/wiki/SC1128), so it has no effect. As a followup to pytorch#58275, this PR removes that shebang to reduce confusion, so now all Python shebangs in this repo are `python3`. Pull Request resolved: pytorch#58409 Reviewed By: walterddr Differential Revision: D28478469 Pulled By: samestep fbshipit-source-id: c17684c8651e45d3fc383cbbc04a31192d10f52f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only line (not in
third_party) matching the regex^#!.*python2, and it is not the first line of its file, so it has no effect. As a followup to #58275, this PR removes that shebang to reduce confusion, so now all Python shebangs in this repo arepython3.