Closed
Conversation
[ghstack-poisoned]
This was referenced Dec 11, 2020
Closed
added 4 commits
December 11, 2020 12:31
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. - Add `has_bool_tensor` checks that will be crucial in next PRs in this stack [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. - Add `has_bool_tensor` checks that will be crucial in next PRs in this stack [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. - Add `has_bool_tensor` checks that will be crucial in next PRs in this stack [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. - Add `has_bool_tensor` checks that will be crucial in next PRs in this stack [ghstack-poisoned]
added 2 commits
December 15, 2020 16:13
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. - Add `has_bool_tensor` checks that will be crucial in next PRs in this stack [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
zou3519
reviewed
Dec 17, 2020
Contributor
zou3519
left a comment
There was a problem hiding this comment.
Have some questions and suggestions
Comment on lines
+341
to
+351
| std::vector<Tensor> foreach_tensor_neg_cuda(TensorList tensors) { | ||
| check_foreach_api_restrictions(tensors); | ||
| TORCH_CHECK(tensors[0].scalar_type() != kBool, | ||
| "Negation, the `-` operator, on a bool tensor is not supported. " | ||
| "If you are trying to invert a mask, use the `~` or `logical_not()` operator instead."); | ||
|
|
||
| if (!can_use_fast_route(tensors)) { | ||
| return at::native::foreach_tensor_neg_slow(tensors); | ||
| } | ||
|
|
||
| return foreach_unary_op_complex_bfloat16<std::negate>(tensors); | ||
| return all_types_half_bfloat16<std::negate>(tensors); |
Contributor
There was a problem hiding this comment.
Why is the new check needed? Also, this updates the semantics of neg, right?
Contributor
Author
There was a problem hiding this comment.
It doesnt change the behavior but an error. it will match the error of torch.neg in case of bool input
Comment on lines
+404
to
+406
| if (at::isComplexType(t.scalar_type()) || | ||
| at::isIntegralType(t.scalar_type(), /*includeBool=*/true)) { | ||
| has_complex_or_integer = true; |
Contributor
There was a problem hiding this comment.
This is fixing a bug, right? Should we add a test for it?
Contributor
Author
There was a problem hiding this comment.
It came from future PRs. I was breaking one PR into pieces and it came here by mistake. removed for now.
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
zou3519
approved these changes
Dec 17, 2020
Contributor
zou3519
left a comment
There was a problem hiding this comment.
Thanks, everything is clearer now!
added 5 commits
December 17, 2020 15:52
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
This was referenced Dec 21, 2020
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
This was referenced Jan 25, 2021
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
added 2 commits
January 26, 2021 14:03
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
added 4 commits
January 27, 2021 07:18
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Differential Revision: [D25502940](https://our.internmc.facebook.com/intern/diff/D25502940) ---------- - Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. [ghstack-poisoned]
Contributor
Contributor
|
@izdeby were Natalia's comments above addressed? #49248 (comment) and #49248 (comment) |
Contributor
|
This pull request has been reverted by d1bc1ab. |
izdeby
pushed a commit
that referenced
this pull request
Feb 18, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) [ghstack-poisoned]
izdeby
pushed a commit
that referenced
this pull request
Feb 18, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) [ghstack-poisoned]
izdeby
pushed a commit
that referenced
this pull request
Feb 22, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) ------- Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. Update abs test to test ints. [ghstack-poisoned]
izdeby
pushed a commit
that referenced
this pull request
Mar 1, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) ------- Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. Update abs test to test ints. [ghstack-poisoned]
izdeby
pushed a commit
that referenced
this pull request
Mar 2, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) ------- Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. Update abs test to test ints. [ghstack-poisoned]
izdeby
pushed a commit
that referenced
this pull request
Mar 3, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) ------- Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. Update abs test to test ints. [ghstack-poisoned]
izdeby
pushed a commit
that referenced
this pull request
Mar 4, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) ------- Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. Update abs test to test ints. [ghstack-poisoned]
izdeby
pushed a commit
that referenced
this pull request
Mar 4, 2021
original PR - #49248 Differential Revision: [D26323605](https://our.internmc.facebook.com/intern/diff/D26323605) ------- Refactor ForeachUnaryOps.cu to better see what dtypes are supported for ops. Update abs test to test ints. [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25502940