Refactor foreach pointwise ops tests to use OpInfo by izdeby · Pull Request #51060 · pytorch/pytorch

izdeby · 2021-01-25T23:30:37Z

Stack from ghstack:

wip #52450 wip
[wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor #49039 [wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor
[WIP] Add type promotion to a fast path for foreach APIs #52449 [WIP] Add type promotion to a fast path for foreach APIs
[WIP] Support broadcasting via slow path #52448 [WIP] Support broadcasting via slow path
[wip] Pushed unsupported scenarios to slow path #48224 [wip] Pushed unsupported scenarios to slow path
Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170 Updated foreach pointwise ops to support complex and bloat16 on CUDA
Update foreach max/min #49714 Update foreach max/min
Refactor foreach pointwise ops tests to use OpInfo #51060 Refactor foreach pointwise ops tests to use OpInfo
Refactor foreach binary ops tests with tensor lists to use OpInfo #51059 Refactor foreach binary ops tests with tensor lists to use OpInfo
Refactor foreach binary ops tests with scalars to use OpInfo #51058 Refactor foreach binary ops tests with scalars to use OpInfo
Refactor foreach unary ops tests to use OpInfo #49712 Refactor foreach unary ops tests to use OpInfo

Refactor foreach pointwise ops tests to use OpInfo

Differential Revision: D26103908

[ghstack-poisoned]

facebook-github-bot · 2021-01-25T23:30:53Z

💊 CI failures summary and remediations

As of commit d1f9c1f (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Mar 19 00:21:24 [E request_callback_no_python.cpp:656] Received error while processing request type 256: The following operation failed in the TorchScript interpreter.

Mar 19 00:21:24 [E request_callback_no_python.cpp:656] Received error while processing request type 256: The following operation failed in the TorchScript interpreter.
Mar 19 00:21:24 Traceback of TorchScript (most recent call last):
Mar 19 00:21:24   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/distributed/rpc/jit/rpc_test.py", line 826, in run_ref_script_module
Mar 19 00:21:24     ref_script_module: RRef[MyModuleInterface], t: Tensor
Mar 19 00:21:24 ) -> Tensor:
Mar 19 00:21:24     module = ref_script_module.to_here()
Mar 19 00:21:24              ~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
Mar 19 00:21:24     return module.forward() + t
Mar 19 00:21:24 RuntimeError: UserRRef(rref_id=GloballyUniqueId(created_on=2, local_id=0), fork_id=GloballyUniqueId(created_on=2, local_id=3)) is an RRef to a ScriptModule. It can't be sent through RPC from owner, WorkerInfo(id=3, name=worker3), to user, WorkerInfo(id=2, name=worker2).
Mar 19 00:21:24 
Mar 19 00:21:24 [E request_callback_no_python.cpp:656] Received error while processing request type 256: The following operation failed in the TorchScript interpreter.
Mar 19 00:21:24 Traceback of TorchScript (most recent call last):
Mar 19 00:21:24   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/distributed/rpc/jit/rpc_test.py", line 826, in run_ref_script_module
Mar 19 00:21:24     ref_script_module: RRef[MyModuleInterface], t: Tensor
Mar 19 00:21:24 ) -> Tensor:
Mar 19 00:21:24     module = ref_script_module.to_here()
Mar 19 00:21:24              ~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
Mar 19 00:21:24     return module.forward() + t
Mar 19 00:21:24 RuntimeError: UserRRef(rref_id=GloballyUniqueId(created_on=1, local_id=0), fork_id=GloballyUniqueId(created_on=1, local_id=3)) is an RRef to a ScriptModule. It can't be sent through RPC from owner, WorkerInfo(id=2, name=worker2), to user, WorkerInfo(id=1, name=worker1).
Mar 19 00:21:24 
Mar 19 00:21:24 ok (2.448s)

1 failure not recognized by patterns:

Job	Step	Action
^flake8-py3	^{Add annotations}	🔁 rerun

1 job timed out:

pytorch_linux_xenial_py3_6_gcc5_4_test

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

[ghstack-poisoned]

------- Refactor foreach pointwise ops tests to use OpInfo [ghstack-poisoned]

mruberry · 2021-01-27T17:32:37Z

torch/testing/_internal/common_methods_invocations.py

+                    method=torch._foreach_addcmul,
+                    inplace=torch._foreach_addcmul_,
+                    ref=torch.addcmul,
+                    dtypes=all_types(),


@ngimel had an interesting idea that these could acquire their dtypes from the reference operation's OpInfo, at least when that OpInfo exists. For example, the OpInfo for asin can be acquired by matching reference and the .op attribute of the OpInfo.

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

ghstack-source-id: d99404d Pull Request resolved: #51060

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

facebook-github-bot · 2021-04-09T09:43:42Z

Hi @izdeby!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

refactor foreach pointwise ops tests to use OpInfo

0ddd937

[ghstack-poisoned]

facebook-github-bot added the cla signed label Jan 25, 2021

izdeby mentioned this pull request Jan 25, 2021

[wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor #49039

Closed

Update on "refactor foreach pointwise ops tests to use OpInfo"

a6752cf

[ghstack-poisoned]

izdeby mentioned this pull request Jan 26, 2021

Refactor ForeachUtils.h #51131

Closed

Update on "refactor foreach pointwise ops tests to use OpInfo"

46ce721

[ghstack-poisoned]

izdeby changed the title ~~refactor foreach pointwise ops tests to use OpInfo~~ Refactor foreach pointwise ops tests to use OpInfo Jan 26, 2021

Update on "Refactor foreach pointwise ops tests to use OpInfo"

94c1823

------- Refactor foreach pointwise ops tests to use OpInfo [ghstack-poisoned]

izdeby mentioned this pull request Jan 27, 2021

Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170

Closed

Update on "Refactor foreach pointwise ops tests to use OpInfo"

b7263ff

------- Refactor foreach pointwise ops tests to use OpInfo [ghstack-poisoned]

izdeby requested review from gchanan, mruberry, ngimel and zou3519 and removed request for zou3519 January 27, 2021 15:26

Update on "Refactor foreach pointwise ops tests to use OpInfo"

9cca925

------- Refactor foreach pointwise ops tests to use OpInfo [ghstack-poisoned]

mruberry reviewed Jan 27, 2021

View reviewed changes

Iurii Zdebskyi added 2 commits January 29, 2021 09:22

Update on "Refactor foreach pointwise ops tests to use OpInfo"

86e9f7c

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

1e4b29f

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

9e0ce6f

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

izdeby pushed a commit that referenced this pull request Feb 4, 2021

Refactor foreach pointwise ops tests to use OpInfo

aa27214

ghstack-source-id: d99404d Pull Request resolved: #51060

Update on "Refactor foreach pointwise ops tests to use OpInfo"

337fae2

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

This was referenced Feb 8, 2021

Update foreach APIs to use scalar lists #51893

Closed

Refactor ForeachUnaryOp.cu #51894

Closed

Update on "Refactor foreach pointwise ops tests to use OpInfo"

d40f396

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

This was referenced Feb 18, 2021

[WIP] Support broadcasting via slow path #52448

Closed

[WIP] Add type promotion to a fast path for foreach APIs #52449

Closed

wip #52450

Closed

Iurii Zdebskyi and others added 14 commits February 18, 2021 12:15

Update on "Refactor foreach pointwise ops tests to use OpInfo"

038c1a2

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

47bea94

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

f6e4e62

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

9eab002

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

85944e9

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

ed2852e

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

85ba177

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

e5fb855

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

06a60fb

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

c3bfa89

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

27da3bc

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

a55c475

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

215646b

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

Update on "Refactor foreach pointwise ops tests to use OpInfo"

d1f9c1f

------- Refactor foreach pointwise ops tests to use OpInfo Differential Revision: [D26103908](https://our.internmc.facebook.com/intern/diff/D26103908) [ghstack-poisoned]

pytorchbot added the open source label Apr 9, 2021

ngimel removed their request for review May 30, 2021 23:40

zou3519 removed their request for review June 28, 2021 13:31

pytorchbot added the Stale label Apr 12, 2022

github-actions bot closed this May 12, 2022

facebook-github-bot deleted the gh/izdeby/77/head branch June 11, 2022 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor foreach pointwise ops tests to use OpInfo#51060

Refactor foreach pointwise ops tests to use OpInfo#51060
izdeby wants to merge 26 commits intogh/izdeby/77/basefrom
gh/izdeby/77/head

izdeby commented Jan 25, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Jan 25, 2021 •

edited

Loading

Uh oh!

mruberry Jan 27, 2021

Uh oh!

facebook-github-bot commented Apr 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

izdeby commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

1 failure not recognized by patterns:

Uh oh!

mruberry Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 9, 2021

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

izdeby commented Jan 25, 2021 •

edited

Loading

facebook-github-bot commented Jan 25, 2021 •

edited

Loading