Refactor foreach binary ops tests with tensor lists to use OpInfo by izdeby · Pull Request #51059 · pytorch/pytorch

izdeby · 2021-01-25T23:30:27Z

Stack from ghstack:

wip #52450 wip
[wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor #49039 [wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor
[WIP] Add type promotion to a fast path for foreach APIs #52449 [WIP] Add type promotion to a fast path for foreach APIs
[WIP] Support broadcasting via slow path #52448 [WIP] Support broadcasting via slow path
[wip] Pushed unsupported scenarios to slow path #48224 [wip] Pushed unsupported scenarios to slow path
Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170 Updated foreach pointwise ops to support complex and bloat16 on CUDA
Update foreach max/min #49714 Update foreach max/min
Refactor foreach binary ops tests with tensor lists to use OpInfo #51059 Refactor foreach binary ops tests with tensor lists to use OpInfo
Refactor foreach binary ops tests with scalars to use OpInfo #51058 Refactor foreach binary ops tests with scalars to use OpInfo

Updated foreach binary ops tests with tensor lists to use OpInfo

Differential Revision: D26103907

[ghstack-poisoned]

facebook-github-bot · 2021-01-25T23:30:41Z

💊 CI failures summary and remediations

As of commit ef25e4e (more details on the Dr. CI page):

2/2 failures possibly* introduced in this PR
- 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_bionic_py3_6_clang9_noarch_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 01 18:46:23 RuntimeError: test_foreach failed!

Apr 01 18:46:23 FAILED (errors=10, skipped=367)
Apr 01 18:46:23 
Apr 01 18:46:23 Generating XML reports...
Apr 01 18:46:23 Generated XML report: test-reports/python-unittest/test_foreach/TEST-TestForeachCPU-20210401184604.xml
Apr 01 18:46:23 Generated XML report: test-reports/python-unittest/test_foreach/TEST-TestForeachMETA-20210401184604.xml
Apr 01 18:46:23 Traceback (most recent call last):
Apr 01 18:46:23   File "test/run_test.py", line 1094, in <module>
Apr 01 18:46:23     main()
Apr 01 18:46:23   File "test/run_test.py", line 1073, in main
Apr 01 18:46:23     raise RuntimeError(err_message)
Apr 01 18:46:23 RuntimeError: test_foreach failed!
Apr 01 18:46:24 
Apr 01 18:46:24 real	11m18.089s
Apr 01 18:46:24 user	12m26.490s
Apr 01 18:46:24 sys	1m43.247s
Apr 01 18:46:24 + cleanup
Apr 01 18:46:24 + retcode=1
Apr 01 18:46:24 + set +x
Apr 01 18:46:24 =================== sccache compilation log ===================
Apr 01 18:46:24 =========== If your build fails, please take a look at the log above for possible reasons ===========
Apr 01 18:46:24 Compile requests                      32

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

… OpInfo" [ghstack-poisoned]

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo [ghstack-poisoned]

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

ghstack-source-id: 9b1b7bc Pull Request resolved: #51059

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

facebook-github-bot · 2021-04-09T09:45:17Z

Hi @izdeby!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

refactor foreach binary ops tests with tensor lists to use OpInfo

9cad176

[ghstack-poisoned]

facebook-github-bot added the cla signed label Jan 25, 2021

izdeby mentioned this pull request Jan 25, 2021

Update foreach APIs to use scalar lists #48223

Closed

Update on "refactor foreach binary ops tests with tensor lists to use…

b6272ab

… OpInfo" [ghstack-poisoned]

izdeby mentioned this pull request Jan 26, 2021

Refactor ForeachUtils.h #51131

Closed

Update on "refactor foreach binary ops tests with tensor lists to use…

3e5a878

… OpInfo" [ghstack-poisoned]

izdeby changed the title ~~refactor foreach binary ops tests with tensor lists to use OpInfo~~ Refactor foreach binary ops tests with tensor lists to use OpInfo Jan 26, 2021

Update on "Refactor foreach binary ops tests with tensor lists to use…

75c6c1c

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo [ghstack-poisoned]

izdeby mentioned this pull request Jan 27, 2021

Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170

Closed

Update on "Refactor foreach binary ops tests with tensor lists to use…

9e57a01

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo [ghstack-poisoned]

izdeby requested review from gchanan, mruberry, ngimel and zou3519 January 27, 2021 15:26

Iurii Zdebskyi added 5 commits January 27, 2021 09:23

Update on "Refactor foreach binary ops tests with tensor lists to use…

d02fa1f

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

0f5da13

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

29df3eb

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

522fa81

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

8780738

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

izdeby pushed a commit that referenced this pull request Feb 4, 2021

Refactor foreach binary ops tests with tensor lists to use OpInfo

7d92922

ghstack-source-id: 9b1b7bc Pull Request resolved: #51059

Update on "Refactor foreach binary ops tests with tensor lists to use…

128cb85

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

This was referenced Feb 8, 2021

Update foreach APIs to use scalar lists #51893

Closed

Refactor ForeachUnaryOp.cu #51894

Closed

Update on "Refactor foreach binary ops tests with tensor lists to use…

085ffc3

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

This was referenced Feb 18, 2021

[WIP] Support broadcasting via slow path #52448

Closed

[WIP] Add type promotion to a fast path for foreach APIs #52449

Closed

wip #52450

Closed

Iurii Zdebskyi and others added 17 commits February 18, 2021 12:15

Update on "Refactor foreach binary ops tests with tensor lists to use…

7e29ad7

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

c1752a9

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

248ba7e

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

50816f7

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

48cdad4

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

40c1164

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

f5ab53a

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

e9e964c

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

5580cf1

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

9959900

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

4443071

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

f8c8105

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

f03b3a3

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

14e28a5

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

ff4289d

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

359e01a

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

Update on "Refactor foreach binary ops tests with tensor lists to use…

ef25e4e

… OpInfo" ------ Updated foreach binary ops tests with tensor lists to use OpInfo Differential Revision: [D26103907](https://our.internmc.facebook.com/intern/diff/D26103907) [ghstack-poisoned]

pytorchbot added the open source label Apr 9, 2021

ngimel removed their request for review May 30, 2021 23:43

zou3519 removed their request for review June 28, 2021 13:31

mruberry closed this Jan 24, 2022

facebook-github-bot deleted the gh/izdeby/76/head branch February 24, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor foreach binary ops tests with tensor lists to use OpInfo#51059

Refactor foreach binary ops tests with tensor lists to use OpInfo#51059
izdeby wants to merge 29 commits intogh/izdeby/76/basefrom
gh/izdeby/76/head

izdeby commented Jan 25, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Jan 25, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

izdeby commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_linux_bionic_py3_6_clang9_noarch_test (1/1)

Uh oh!

facebook-github-bot commented Apr 9, 2021

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

izdeby commented Jan 25, 2021 •

edited

Loading

facebook-github-bot commented Jan 25, 2021 •

edited

Loading