Update foreach max/min by izdeby · Pull Request #49714 · pytorch/pytorch

izdeby · 2020-12-21T23:54:59Z

Stack from ghstack:

wip #52450 wip
[wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor #49039 [wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor
[WIP] Add type promotion to a fast path for foreach APIs #52449 [WIP] Add type promotion to a fast path for foreach APIs
[WIP] Support broadcasting via slow path #52448 [WIP] Support broadcasting via slow path
[wip] Pushed unsupported scenarios to slow path #48224 [wip] Pushed unsupported scenarios to slow path
Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170 Updated foreach pointwise ops to support complex and bloat16 on CUDA
Update foreach max/min #49714 Update foreach max/min
Refactor foreach binary ops tests with tensor lists to use OpInfo #51059 Refactor foreach binary ops tests with tensor lists to use OpInfo
Refactor foreach binary ops tests with scalars to use OpInfo #51058 Refactor foreach binary ops tests with scalars to use OpInfo

Differential Revision: D25674139

Add support for torch.bool and torch.bfloat16 for foreach max/min
Updated the tests to use OpInfo

[ghstack-poisoned]

facebook-github-bot · 2020-12-21T23:55:11Z

💊 CI failures summary and remediations

As of commit f32e2e0 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

zou3519 · 2020-12-22T16:13:40Z

test/test_foreach.py

        self._test_pointwise_op(device, dtype, torch._foreach_addcdiv, torch._foreach_addcdiv_, torch.addcdiv)

-    @dtypes(*torch.testing.get_all_dtypes(include_bfloat16=False, include_bool=False, include_complex=False))
+    @dtypes(*torch.testing.get_all_dtypes())


What added bfloat16 and bool support? Were those supported all along?

I've added support for torch.bool and torch.bfloat16 in this PR

zou3519 · 2020-12-22T16:15:25Z

test/test_foreach.py

        self._test_pointwise_op(device, dtype, torch._foreach_addcdiv, torch._foreach_addcdiv_, torch.addcdiv)

-    @dtypes(*torch.testing.get_all_dtypes(include_bfloat16=False, include_bool=False, include_complex=False))
+    @dtypes(*torch.testing.get_all_dtypes())


Is there a type promotion test for foreach_maximum / foreach_minimum, or is that out of the scope of this PR?

Type promotion will be tested in upcoming PRs once we push different dtype behavior from error to slow path.

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) [ghstack-poisoned]

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min [ghstack-poisoned]

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

facebook-github-bot · 2021-04-09T09:42:28Z

Hi @izdeby!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Update foreach max/min

8e620c0

[ghstack-poisoned]

facebook-github-bot added the cla signed label Dec 21, 2020

izdeby mentioned this pull request Dec 21, 2020

[wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor #49039

Closed

zou3519 reviewed Dec 22, 2020

View reviewed changes

izdeby and others added 3 commits January 12, 2021 09:02

Update on "Update foreach max/min"

eb17c13

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) [ghstack-poisoned]

Update on "Update foreach max/min"

05058ee

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) [ghstack-poisoned]

Update on "Update foreach max/min"

cc08606

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) [ghstack-poisoned]

This was referenced Jan 25, 2021

Refactor foreach binary ops tests with scalars to use OpInfo #51058

Closed

Refactor foreach binary ops tests with tensor lists to use OpInfo #51059

Closed

Refactor foreach pointwise ops tests to use OpInfo #51060

Closed

Update on "Update foreach max/min"

213934c

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) [ghstack-poisoned]

izdeby mentioned this pull request Jan 26, 2021

Refactor ForeachUtils.h #51131

Closed

Update on "Update foreach max/min"

33cded0

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) [ghstack-poisoned]

izdeby changed the title ~~Update foreach max/min~~ Update complex check for foreach max/min Jan 26, 2021

izdeby changed the title ~~Update complex check for foreach max/min~~ Update foreach max/min Jan 26, 2021

Update on "Update foreach max/min"

2bf1e81

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min [ghstack-poisoned]

izdeby mentioned this pull request Jan 27, 2021

Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170

Closed

Update on "Update foreach max/min"

9dc13a7

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min [ghstack-poisoned]

izdeby requested review from gchanan, ngimel and zou3519 January 27, 2021 15:27

Iurii Zdebskyi added 2 commits January 27, 2021 09:23

Update on "Update foreach max/min"

f1ef8a7

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min [ghstack-poisoned]

Update on "Update foreach max/min"

9cdb683

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min [ghstack-poisoned]

This was referenced Feb 8, 2021

Update foreach APIs to use scalar lists #51893

Closed

Refactor ForeachUnaryOp.cu #51894

Closed

Update on "Update foreach max/min"

4c7d5d8

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

This was referenced Feb 18, 2021

[WIP] Support broadcasting via slow path #52448

Closed

[WIP] Add type promotion to a fast path for foreach APIs #52449

Closed

wip #52450

Closed

Iurii Zdebskyi and others added 17 commits February 18, 2021 12:15

Update on "Update foreach max/min"

87131e8

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

5e43911

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

970775e

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

c850b1c

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

29877ae

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

a00eb99

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

dc44a11

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

4cb803b

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

891e054

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

dab7d57

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

fd4b91f

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

29d4eab

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

e3fb637

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

e19ff82

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

a61c84f

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

6d47b84

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

Update on "Update foreach max/min"

f32e2e0

Differential Revision: [D25674139](https://our.internmc.facebook.com/intern/diff/D25674139) ------- - Add support for torch.bool and torch.bfloat16 for foreach max/min - Updated the tests to use OpInfo [ghstack-poisoned]

pytorchbot added the open source label Apr 9, 2021

ngimel removed their request for review May 30, 2021 23:44

zou3519 removed their request for review June 28, 2021 13:31

pytorchbot added the Stale label Apr 12, 2022

github-actions bot closed this May 12, 2022

facebook-github-bot deleted the gh/izdeby/74/head branch June 11, 2022 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update foreach max/min#49714

Update foreach max/min#49714
izdeby wants to merge 32 commits intogh/izdeby/74/basefrom
gh/izdeby/74/head

izdeby commented Dec 21, 2020 •

edited

Loading

Uh oh!

facebook-github-bot commented Dec 21, 2020 •

edited

Loading

Uh oh!

zou3519 Dec 22, 2020

Uh oh!

izdeby Feb 2, 2021

Uh oh!

zou3519 Dec 22, 2020

Uh oh!

izdeby Feb 2, 2021

Uh oh!

facebook-github-bot commented Apr 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

izdeby commented Dec 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Dec 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

zou3519 Dec 22, 2020

Choose a reason for hiding this comment

Uh oh!

izdeby Feb 2, 2021

Choose a reason for hiding this comment

Uh oh!

zou3519 Dec 22, 2020

Choose a reason for hiding this comment

Uh oh!

izdeby Feb 2, 2021

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 9, 2021

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

izdeby commented Dec 21, 2020 •

edited

Loading

facebook-github-bot commented Dec 21, 2020 •

edited

Loading