Refactor ForeachUtils.h by izdeby · Pull Request #51131 · pytorch/pytorch

izdeby · 2021-01-26T19:32:10Z

Stack from ghstack:

wip #52450 wip
[wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor #49039 [wip] Replace optimizers in torch.optim with the ones from torch.optim._multi_tensor
[WIP] Add type promotion to a fast path for foreach APIs #52449 Add type promotion to a fast path for foreach APIs
[WIP] Support broadcasting via slow path #52448 Support broadcasting via slow path
[wip] Pushed unsupported scenarios to slow path #48224 [wip] Pushed unsupported scenarios to slow path
Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170 Updated foreach pointwise ops to support complex and bloat16 on CUDA
Update foreach max/min #49714 Update foreach max/min
Refactor foreach pointwise ops tests to use OpInfo #51060 Refactor foreach pointwise ops tests to use OpInfo
Refactor foreach binary ops tests with tensor lists to use OpInfo #51059 Refactor foreach binary ops tests with tensor lists to use OpInfo
Refactor foreach binary ops tests with scalars to use OpInfo #51058 Refactor foreach binary ops tests with scalars to use OpInfo
Refactor foreach unary ops tests to use OpInfo #49712 Refactor foreach unary ops tests to use OpInfo
Update foreach binary ops with a single scalar and list of tensors #49250 Update foreach binary ops with a single scalar and list of tensors
Update foreach binary ops with a scalar list #49249 Update foreach binary ops with a scalar list
Refactor ForeachUtils.h #51131 Refactor ForeachUtils.h

Refactored can_use_fast_route logic in ForeachUtils.h.
Fixed related bugs in test_foreach.py

Differential Revision: D26103904

[ghstack-poisoned]

facebook-github-bot · 2021-01-26T19:32:25Z

💊 CI failures summary and remediations

As of commit 4b82819 (more details on the Dr. CI page):

2/2 failures possibly* introduced in this PR
- 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job	Step	Action
^{pytorch_linux_xenial_py3_6_gcc5_4_test}	^{Run tests}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

[ghstack-poisoned]

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py [ghstack-poisoned]

zou3519

some questions

aten/src/ATen/native/ForeachUtils.h

test/test_foreach.py

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

aten/src/ATen/native/ForeachUtils.h

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

aten/src/ATen/native/ForeachUtils.h

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

ghstack-source-id: 7eb649a Pull Request resolved: #51131

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

facebook-github-bot · 2021-03-13T21:41:23Z

@izdeby merged this pull request in 84af0c7.

Summary: Pull Request resolved: pytorch#51131 -------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D26103904 Pulled By: izdeby fbshipit-source-id: b3859b39adaab55c87dab6f7709d227adc0f6342

Refactor ForeachUtils.h

65fac9d

[ghstack-poisoned]

facebook-github-bot added the cla signed label Jan 26, 2021

This was referenced Jan 26, 2021

Refactor foreach binary ops tests with scalars to use OpInfo #51058

Closed

Refactor foreach binary ops tests with tensor lists to use OpInfo #51059

Closed

Iurii Zdebskyi added 2 commits January 26, 2021 14:03

Update on "Refactor ForeachUtils.h"

15b7770

[ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

7c67f3d

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py [ghstack-poisoned]

izdeby mentioned this pull request Jan 27, 2021

Updated foreach pointwise ops to support complex and bloat16 on CUDA #51170

Closed

Update on "Refactor ForeachUtils.h"

4cf82ce

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py [ghstack-poisoned]

izdeby requested review from gchanan, ngimel and zou3519 January 27, 2021 15:21

Update on "Refactor ForeachUtils.h"

87e4ce2

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py [ghstack-poisoned]

zou3519 reviewed Jan 27, 2021

View reviewed changes

Iurii Zdebskyi added 2 commits January 29, 2021 09:22

Update on "Refactor ForeachUtils.h"

af2aa25

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

9e3c042

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

izdeby requested a review from zou3519 January 29, 2021 17:28

zou3519 reviewed Jan 29, 2021

View reviewed changes

aten/src/ATen/native/ForeachUtils.h Outdated Show resolved Hide resolved

Update on "Refactor ForeachUtils.h"

1160feb

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

izdeby requested a review from zou3519 February 1, 2021 15:54

zou3519 approved these changes Feb 1, 2021

View reviewed changes

aten/src/ATen/native/ForeachUtils.h Outdated Show resolved Hide resolved

Update on "Refactor ForeachUtils.h"

e57819a

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

izdeby pushed a commit that referenced this pull request Feb 4, 2021

Refactor ForeachUtils.h

e1f4212

ghstack-source-id: 7eb649a Pull Request resolved: #51131

Update on "Refactor ForeachUtils.h"

da3c3d5

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

This was referenced Feb 8, 2021

Update foreach APIs to use scalar lists #51893

Closed

Refactor ForeachUnaryOp.cu #51894

Closed

Update on "Refactor ForeachUtils.h"

ff70ef6

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

This was referenced Feb 18, 2021

[WIP] Support broadcasting via slow path #52448

Closed

[WIP] Add type promotion to a fast path for foreach APIs #52449

Closed

wip #52450

Closed

Iurii Zdebskyi and others added 12 commits February 18, 2021 12:15

Update on "Refactor ForeachUtils.h"

ad63b5f

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

4683175

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

a9b05c5

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

aea5ba3

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

5ef0512

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

0523d3f

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

12bf0a9

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

2a900e7

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

5a90f54

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

d357cce

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

0c19b32

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

Update on "Refactor ForeachUtils.h"

4b82819

-------- - Refactored `can_use_fast_route` logic in ForeachUtils.h. - Fixed related bugs in test_foreach.py Differential Revision: [D26103904](https://our.internmc.facebook.com/intern/diff/D26103904) [ghstack-poisoned]

facebook-github-bot closed this in 84af0c7 Mar 13, 2021

facebook-github-bot added the Merged label Mar 13, 2021

facebook-github-bot deleted the gh/izdeby/78/head branch March 17, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor ForeachUtils.h#51131

Refactor ForeachUtils.h#51131
izdeby wants to merge 23 commits intogh/izdeby/78/basefrom
gh/izdeby/78/head

izdeby commented Jan 26, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Jan 26, 2021 •

edited

Loading

Uh oh!

zou3519 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Mar 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

izdeby commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

1 failure not recognized by patterns:

Uh oh!

zou3519 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Mar 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

izdeby commented Jan 26, 2021 •

edited

Loading

facebook-github-bot commented Jan 26, 2021 •

edited

Loading