Remove codegen logic to support non-c10-full ops#49164
Closed
smessmer wants to merge 50 commits intogh/smessmer/285/basefrom
Closed
Remove codegen logic to support non-c10-full ops#49164smessmer wants to merge 50 commits intogh/smessmer/285/basefrom
smessmer wants to merge 50 commits intogh/smessmer/285/basefrom
Conversation
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This was referenced Dec 10, 2020
smessmer
added a commit
that referenced
this pull request
Dec 10, 2020
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) ghstack-source-id: 118295716 Pull Request resolved: #49164
💊 CI failures summary and remediationsAs of commit 981282a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 250 times. |
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 10, 2020
Pull Request resolved: #49164 This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. ghstack-source-id: 118318428 Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/)
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 11, 2020
Pull Request resolved: #49164 This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. ghstack-source-id: 118379649 Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/)
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 11, 2020
Pull Request resolved: #49164 This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. ghstack-source-id: 118380590 Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/)
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
ezyang
approved these changes
Jan 4, 2021
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49510 Adding old style operators with out arguments will break XLA. This prevents that. See for background: https://fb.workplace.com/groups/pytorch.dev/permalink/809934446251704/ This is a temporary change that will prevent this breakage for the next couple of days until the problem is resolved for good. It will be deleted in pytorch#49164 then. ghstack-source-id: 118756437 (Note: this ignores all push blocking failures!) Test Plan: waitforsandcastle Reviewed By: bhosmer Differential Revision: D25599112 fbshipit-source-id: 6b0ca4da4b55da8aab9d1b332cd9f68e7602301e
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. Differential Revision: [D25462977](https://our.internmc.facebook.com/intern/diff/D25462977/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in e4c41b6. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 14, 2021
Summary: Pull Request resolved: pytorch#49164 This PR removes the logic paths in codegen that were responsible for handling non-c10-full ops. This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet. ghstack-source-id: 119450487 Test Plan: waitforsandcastle Reviewed By: ezyang Differential Revision: D25462977 fbshipit-source-id: 7e70d14bea96948f5056d98125f3e6ba6bd78285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
use_c10_dispatcher: fulllines #49259 Removeuse_c10_dispatcher: fulllinesThis PR removes the logic paths in codegen that were responsible for handling non-c10-full ops.
This only goes through our basic codegen. It does not simplify C++ code yet and it does not remove the codegen for generated unboxing wrappers yet.
Differential Revision: D25462977