Remove `use_c10_dispatcher: full` lines#49259

Closed

smessmer wants to merge 38 commits intogh/smessmer/289/basefrom

gh/smessmer/289/head

Contributor

smessmer commented Dec 11, 2020 •

edited

Loading

Stack from ghstack:

Remove backward and requires_grad from Autograd backend key #49613 Remove backward and requires_grad from Autograd backend key
Remove use_c10_dispatcher: full lines #49259 Remove use_c10_dispatcher: full lines
Remove generated_unboxing_wrappers and setManuallyBoxedKernel #49251 Remove generated_unboxing_wrappers and setManuallyBoxedKernel
Remove .impl_UNBOXED() and functionalities associated with it #49220 Remove .impl_UNBOXED() and functionalities associated with it
Remove codegen logic to support non-c10-full ops #49164 Remove codegen logic to support non-c10-full ops

Since use_c10_dispatcher: full is now the default, we can remove all those pesky lines mentioning it. Only the use_c10_dispatcher: hacky_wrapper_for_legacy_signatures lines are left.

Differential Revision: D25506526


          Remove use_c10_dispatcher: full lines

f6073ef

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

facebook-github-bot added the cla signed label

This was referenced Dec 11, 2020

Make out ops c10-full (with hacky-wrapper) #48912

Closed

Making ops c10 full: ops returning multiple out arguments #49006

Closed

Making ops c10-full: ops blocked by manual registrations #49007

Closed

Making ops c10-full: Dimname arguments #49008

Closed

Making ops c10 full: out overloads with default arguments #49012

Closed

Making ops c10-full: Generator arguments #49013

Closed

Making ops c10 full: optional out arguments #49083

Closed

Making ops c10-full: optional lists #49088

Closed

Making ops c10-full: Storage arguments #49146

Closed

Making ops c10-full: ConstQuantizerPtr #49150

Closed

Making ops c10-full: list of optional tensors #49138

Closed

Remove codegen logic to support non-c10-full ops #49164

Closed

Remove .impl_UNBOXED() and functionalities associated with it #49220

Closed

Remove generated_unboxing_wrappers and setManuallyBoxedKernel #49251

Closed


          Update on "Remove use_c10_dispatcher: full lines"

e302d18

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

smessmer added a commit that referenced this pull request


          Remove use_c10_dispatcher: full lines

35acba5

Pull Request resolved: #49259

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.
ghstack-source-id: 118432240

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)


          Update on "Remove use_c10_dispatcher: full lines"

ca5f47f

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

smessmer added a commit that referenced this pull request


          Remove use_c10_dispatcher: full lines

ab08ce7

Pull Request resolved: #49259

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.
ghstack-source-id: 118470975

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)


          Update on "Remove use_c10_dispatcher: full lines"

1f3c046

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

e8b193c

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

73c6657

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

smessmer added a commit that referenced this pull request


          Remove use_c10_dispatcher: full lines

37c44fd

Pull Request resolved: #49259

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.
ghstack-source-id: 118660065

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)


          Update on "Remove use_c10_dispatcher: full lines"

ecab915

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

smessmer mentioned this pull request

Remove set_quantizer_ from native_functions.yaml #49463

Closed

smessmer added a commit that referenced this pull request


          Remove use_c10_dispatcher: full lines

f3d3e9d

Pull Request resolved: #49259

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.
ghstack-source-id: 118710662

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

smessmer added 16 commits

December 21, 2020 05:44


          Update on "Remove use_c10_dispatcher: full lines"

3b9545d

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

d614e6c

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

461c403

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

8600e4e

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

f35ab66

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

8cb43c1

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

708d0b1

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

7abe2e9

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

d232725

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

35b7129

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

a0ae19e

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

2172d35

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

dbb1204

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

e4055a7

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

ezyang approved these changes

View reviewed changes

smessmer added 4 commits

January 5, 2021 13:24


          Update on "Remove use_c10_dispatcher: full lines"

6d08999

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

178ba22

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

5f70630

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]


          Update on "Remove use_c10_dispatcher: full lines"

26590f2

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

bhosmer approved these changes

View reviewed changes

bhosmer left a comment

YESSSS

bhosmer commented Jan 6, 2021

it sparks joy


          Update on "Remove use_c10_dispatcher: full lines"

56b6322

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.

Differential Revision: [D25506526](https://our.internmc.facebook.com/intern/diff/D25506526/)

[ghstack-poisoned]

facebook-github-bot closed this in

6643e9f

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Jan 6, 2021

This pull request has been merged in 6643e9f.

facebook-github-bot deleted the gh/smessmer/289/head branch

January 10, 2021 15:17

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request


          Remove use_c10_dispatcher: full lines (pytorch#49259)

a454f74

Summary:
Pull Request resolved: pytorch#49259

Since `use_c10_dispatcher: full` is now the default, we can remove all those pesky lines mentioning it. Only the `use_c10_dispatcher: hacky_wrapper_for_legacy_signatures` lines are left.
ghstack-source-id: 119450485

Test Plan: waitforsandcastle

Reviewed By: ezyang

Differential Revision: D25506526

fbshipit-source-id: 8053618120c0b52ff7c73cacb34bec7eb38f8fe0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged