Remove backward and requires_grad from Autograd backend key#49613
Closed
smessmer wants to merge 27 commits intogh/smessmer/292/basefrom
Closed
Remove backward and requires_grad from Autograd backend key#49613smessmer wants to merge 27 commits intogh/smessmer/292/basefrom
smessmer wants to merge 27 commits intogh/smessmer/292/basefrom
Conversation
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 62ed7bd (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 293 times. |
This was referenced Dec 18, 2020
albanD
reviewed
Dec 18, 2020
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 18, 2020
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 118949300 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 21, 2020
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 118990908 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 22, 2020
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119067456 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 23, 2020
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119085314 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 23, 2020
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119086287 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 23, 2020
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119091239 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 29, 2020
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119175742 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jan 3, 2021
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119269183 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
ezyang
approved these changes
Jan 4, 2021
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jan 5, 2021
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119404174 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jan 6, 2021
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119433441 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jan 6, 2021
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119436049 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
bhosmer
approved these changes
Jan 6, 2021
Just following a TODO in the code base... Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jan 6, 2021
Pull Request resolved: #49613 Just following a TODO in the code base... ghstack-source-id: 119450484 Differential Revision: [D25644597](https://our.internmc.facebook.com/intern/diff/D25644597/)
Contributor
|
This pull request has been merged in eef5eb0. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 14, 2021
…49613) Summary: Pull Request resolved: pytorch#49613 Just following a TODO in the code base... ghstack-source-id: 119450484 Test Plan: waitforsandcastle Reviewed By: ezyang Differential Revision: D25644597 fbshipit-source-id: 26f5fa6af480929d0468b0de3ab103813e40d78b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
use_c10_dispatcher: fulllines #49259 Removeuse_c10_dispatcher: fulllinesJust following a TODO in the code base...
Differential Revision: D25644597