Remove .impl_UNBOXED() and functionalities associated with it by smessmer · Pull Request #49220 · pytorch/pytorch

smessmer · 2020-12-11T07:03:33Z

Stack from ghstack:

Remove backward and requires_grad from Autograd backend key #49613 Remove backward and requires_grad from Autograd backend key
Remove use_c10_dispatcher: full lines #49259 Remove use_c10_dispatcher: full lines
Remove generated_unboxing_wrappers and setManuallyBoxedKernel #49251 Remove generated_unboxing_wrappers and setManuallyBoxedKernel
Remove .impl_UNBOXED() and functionalities associated with it #49220 Remove .impl_UNBOXED() and functionalities associated with it
Remove codegen logic to support non-c10-full ops #49164 Remove codegen logic to support non-c10-full ops

Since all ops are c10-full, we can remove .impl_UNBOXED now.
This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels.

Differential Revision: D25490225

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

Since all ops are c10-full, we can remove .impl_UNBOXED now. This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels. Differential Revision: [D25490225](https://our.internmc.facebook.com/intern/diff/D25490225/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25490225/)! [ghstack-poisoned]

… it" Since all ops are c10-full, we can remove .impl_UNBOXED now. This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels. Differential Revision: [D25490225](https://our.internmc.facebook.com/intern/diff/D25490225/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25490225/)! [ghstack-poisoned]

Pull Request resolved: #49220 Since all ops are c10-full, we can remove .impl_UNBOXED now. This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels. ghstack-source-id: 118382014 Differential Revision: [D25490225](https://our.internmc.facebook.com/intern/diff/D25490225/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25490225/)!

facebook-github-bot · 2020-12-11T07:14:04Z

💊 CI failures summary and remediations

As of commit 9c99d93 (more details on the Dr. CI page):

4/4 failures possibly* introduced in this PR
- 2/4 non-CircleCI failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jan 06 19:03:08 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future

Jan 06 19:03:08 At:
Jan 06 19:03:08   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Jan 06 19:03:08   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Jan 06 19:03:08 
Jan 06 19:03:08 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Jan 06 19:03:08 
Jan 06 19:03:08 At:
Jan 06 19:03:08   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Jan 06 19:03:08   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Jan 06 19:03:08 
Jan 06 19:03:08 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Jan 06 19:03:08 
Jan 06 19:03:08 At:
Jan 06 19:03:08   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Jan 06 19:03:08   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Jan 06 19:03:08 
Jan 06 19:03:08 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown)
Jan 06 19:03:08 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown)
Jan 06 19:03:08 [W tensorpipe_agent.cpp:547] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)
Jan 06 19:03:08 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown)
Jan 06 19:03:08 ok (2.559s)

pytorch_windows_vs2019_py36_cuda10.1_test1 (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_nn failed!

  test_ReflectionPad2d (__main__.TestNN) ... ok (1.171s)
  test_ReflectionPad2d_alert_nondeterministic_cuda (__main__.TestNN) ... ok (0.018s)
  test_ReflectionPad2d_cuda (__main__.TestNN) ... ok (0.013s)
  test_ReplicationPad1d (__main__.TestNN) ... ok (0.051s)
  test_ReplicationPad1d_alert_nondeterministic_cuda (__main__.TestNN) ... ok (0.018s)
  test_ReplicationPad1d_cuda (__main__.TestNN) ... Traceback (most recent call last):
  File "run_test.py", line 910, in <module>
    main()
  File "run_test.py", line 889, in main
    raise RuntimeError(err_message)
RuntimeError: test_nn failed!

(base) circleci@PACKER-5FD865C5 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1 
+ cleanup
+ retcode=1
+ set +x


Exited with code exit status 1

1 job timed out:

pytorch_linux_bionic_py3_8_gcc9_coverage_test1

ci.pytorch.org: 1 failed

Failed: pr/pytorch-linux-bionic-rocm3.10-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 501 times.

… it" Since all ops are c10-full, we can remove .impl_UNBOXED now. This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels. Differential Revision: [D25490225](https://our.internmc.facebook.com/intern/diff/D25490225/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25490225/)! [ghstack-poisoned]

ezyang

Good riddance!!!

ezyang · 2021-01-04T19:35:43Z

Guessing this will need an XLA companion?

smessmer · 2021-01-04T21:11:31Z

Guessing this will need an XLA companion?

yes, pytorch/xla#2714 needs to be landed before this

… it" Since all ops are c10-full, we can remove .impl_UNBOXED now. This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels. Differential Revision: [D25490225](https://our.internmc.facebook.com/intern/diff/D25490225/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25490225/)! [ghstack-poisoned]

torch/library.h

… it" Since all ops are c10-full, we can remove .impl_UNBOXED now. This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels. Differential Revision: [D25490225](https://our.internmc.facebook.com/intern/diff/D25490225/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25490225/)! [ghstack-poisoned]

facebook-github-bot · 2021-01-06T22:23:37Z

This pull request has been merged in 4a14020.

…h#49220) Summary: Pull Request resolved: pytorch#49220 Since all ops are c10-full, we can remove .impl_UNBOXED now. This also removes the ability of KernelFunction or CppFunction to store unboxedOnly kernels. ghstack-source-id: 119450489 Test Plan: waitforsandcastle Reviewed By: ezyang Differential Revision: D25490225 fbshipit-source-id: 32de9d591e6a842fe18abc82541580647e9cfdad

facebook-github-bot added the cla signed label Dec 11, 2020

smessmer added 14 commits December 21, 2020 08:45

ezyang approved these changes Jan 4, 2021

View reviewed changes

smessmer added 4 commits January 5, 2021 13:23

bhosmer approved these changes Jan 6, 2021

View reviewed changes

bhosmer reviewed Jan 6, 2021

View reviewed changes

torch/library.h Show resolved Hide resolved

facebook-github-bot closed this in 4a14020 Jan 6, 2021

facebook-github-bot added the Merged label Jan 6, 2021

facebook-github-bot deleted the gh/smessmer/286/head branch January 10, 2021 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove .impl_UNBOXED() and functionalities associated with it#49220

Remove .impl_UNBOXED() and functionalities associated with it#49220
smessmer wants to merge 48 commits intogh/smessmer/286/basefrom
gh/smessmer/286/head

smessmer commented Dec 11, 2020 •

edited

Loading

Uh oh!

facebook-github-bot commented Dec 11, 2020 •

edited

Loading

Uh oh!

ezyang left a comment

Uh oh!

ezyang commented Jan 4, 2021

Uh oh!

smessmer commented Jan 4, 2021

Uh oh!

Uh oh!

facebook-github-bot commented Jan 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

smessmer commented Dec 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Dec 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (1/2)

pytorch_windows_vs2019_py36_cuda10.1_test1 (2/2)

ci.pytorch.org: 1 failed

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Jan 4, 2021

Uh oh!

smessmer commented Jan 4, 2021

Uh oh!

Uh oh!

facebook-github-bot commented Jan 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smessmer commented Dec 11, 2020 •

edited

Loading

facebook-github-bot commented Dec 11, 2020 •

edited

Loading