Prevent accidentally writing old style ops#49510
Closed
smessmer wants to merge 2 commits intogh/smessmer/291/basefrom
Closed
Prevent accidentally writing old style ops#49510smessmer wants to merge 2 commits intogh/smessmer/291/basefrom
smessmer wants to merge 2 commits intogh/smessmer/291/basefrom
Conversation
Adding old style operators with out arguments will break XLA. This prevents that. See for background: https://fb.workplace.com/groups/pytorch.dev/permalink/809934446251704/ This is a temporary change that will prevent this breakage for the next couple of days until the problem is resolved for good. It will be deleted in #49164 then. Differential Revision: [D25599112](https://our.internmc.facebook.com/intern/diff/D25599112/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit cc334bc (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 5 times. |
Adding old style operators with out arguments will break XLA. This prevents that. See for background: https://fb.workplace.com/groups/pytorch.dev/permalink/809934446251704/ This is a temporary change that will prevent this breakage for the next couple of days until the problem is resolved for good. It will be deleted in #49164 then. Differential Revision: [D25599112](https://our.internmc.facebook.com/intern/diff/D25599112/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 16, 2020
Pull Request resolved: #49510 Adding old style operators with out arguments will break XLA. This prevents that. See for background: https://fb.workplace.com/groups/pytorch.dev/permalink/809934446251704/ This is a temporary change that will prevent this breakage for the next couple of days until the problem is resolved for good. It will be deleted in #49164 then. ghstack-source-id: 118756437 Differential Revision: [D25599112](https://our.internmc.facebook.com/intern/diff/D25599112/)
bhosmer
approved these changes
Dec 16, 2020
Contributor
|
This pull request has been merged in 872f648. |
This was referenced Dec 20, 2020
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49510 Adding old style operators with out arguments will break XLA. This prevents that. See for background: https://fb.workplace.com/groups/pytorch.dev/permalink/809934446251704/ This is a temporary change that will prevent this breakage for the next couple of days until the problem is resolved for good. It will be deleted in pytorch#49164 then. ghstack-source-id: 118756437 (Note: this ignores all push blocking failures!) Test Plan: waitforsandcastle Reviewed By: bhosmer Differential Revision: D25599112 fbshipit-source-id: 6b0ca4da4b55da8aab9d1b332cd9f68e7602301e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Adding old style operators with out arguments will break XLA. This prevents that. See for background: https://fb.workplace.com/groups/pytorch.dev/permalink/809934446251704/
This is a temporary change that will prevent this breakage for the next couple of days until the problem is resolved for good.
It will be deleted in #49164 then.
Differential Revision: D25599112