remove hacky_wrapper from BackendSelect#49079
Closed
smessmer wants to merge 3 commits intogh/smessmer/278/basefrom
Closed
remove hacky_wrapper from BackendSelect#49079smessmer wants to merge 3 commits intogh/smessmer/278/basefrom
smessmer wants to merge 3 commits intogh/smessmer/278/basefrom
Conversation
BackendSelect kernels have been changed to be written the new way, so this hacky_wrapper here isn't needed anymore. This PR is not expected to change perf or anything, just simplify the code a bit. The hacky_wrapper here was a no-op and not creating any actual wrappers because it short-cirtuits to not create a wrapper when there is no wrapper needed. Differential Revision: [D25421633](https://our.internmc.facebook.com/intern/diff/D25421633/) [ghstack-poisoned]
This was referenced Dec 9, 2020
💊 CI failures summary and remediationsAs of commit 36cccd1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
bhosmer
approved these changes
Dec 9, 2020
BackendSelect kernels have been changed to be written the new way, so this hacky_wrapper here isn't needed anymore. This PR is not expected to change perf or anything, just simplify the code a bit. The hacky_wrapper here was a no-op and not creating any actual wrappers because it short-cirtuits to not create a wrapper when there is no wrapper needed. Differential Revision: [D25421633](https://our.internmc.facebook.com/intern/diff/D25421633/) [ghstack-poisoned]
This was referenced Dec 10, 2020
BackendSelect kernels have been changed to be written the new way, so this hacky_wrapper here isn't needed anymore. This PR is not expected to change perf or anything, just simplify the code a bit. The hacky_wrapper here was a no-op and not creating any actual wrappers because it short-cirtuits to not create a wrapper when there is no wrapper needed. Differential Revision: [D25421633](https://our.internmc.facebook.com/intern/diff/D25421633/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in c892c3a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
BackendSelect kernels have been changed to be written the new way, so this hacky_wrapper here isn't needed anymore.
This PR is not expected to change perf or anything, just simplify the code a bit. The hacky_wrapper here was a no-op and not creating any actual wrappers
because it short-cirtuits to not create a wrapper when there is no wrapper needed.
Differential Revision: D25421633