Making ops c10-full: Storage arguments#49146
Closed
smessmer wants to merge 20 commits intogh/smessmer/283/basefrom
Closed
Making ops c10-full: Storage arguments#49146smessmer wants to merge 20 commits intogh/smessmer/283/basefrom
smessmer wants to merge 20 commits intogh/smessmer/283/basefrom
Conversation
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
This was referenced Dec 10, 2020
This was referenced Dec 10, 2020
💊 CI failures summary and remediationsAs of commit 6f74e1f (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 106 times. |
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
This was referenced Dec 10, 2020
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
ezyang
approved these changes
Dec 10, 2020
Contributor
ezyang
left a comment
There was a problem hiding this comment.
It's probably worth noting that TorchScript frontend probably doesn't actually support storage haha
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
bhosmer
approved these changes
Dec 11, 2020
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
This was referenced Dec 11, 2020
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. Differential Revision: [D25456799](https://our.internmc.facebook.com/intern/diff/D25456799/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 4431731. |
swolchok
reviewed
Dec 22, 2020
| return static_cast<at::TensorImpl*>(payload.as_intrusive_ptr); | ||
| } | ||
|
|
||
| IValue(at::Storage s) : tag(Tag::Storage), is_intrusive_ptr(static_cast<bool>(s)) { |
Contributor
There was a problem hiding this comment.
Do we really need to conditionally set is_intrusive_ptr here? It looks to me like empty Storage doesn't have a specialized singleton representation; it's just nullptr
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49146 Add support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full. ghstack-source-id: 118710665 (Note: this ignores all push blocking failures!) Test Plan: waitforsandcastle Reviewed By: ezyang Differential Revision: D25456799 fbshipit-source-id: da14f125af352de5fcf05a83a69ad5a69d5a3b45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
use_c10_dispatcher: fulllines #49259 Removeuse_c10_dispatcher: fulllinesAdd support for Storage arguments to IValue and the JIT typing system, and make ops that were blocked on that c10-full.
Differential Revision: D25456799