Making ops c10-full: Dimname arguments by smessmer · Pull Request #49008 · pytorch/pytorch

smessmer · 2020-12-08T08:36:28Z

Stack from ghstack:

Remove use_c10_dispatcher: full lines #49259 Remove use_c10_dispatcher: full lines
Remove generated_unboxing_wrappers and setManuallyBoxedKernel #49251 Remove generated_unboxing_wrappers and setManuallyBoxedKernel
Remove .impl_UNBOXED() and functionalities associated with it #49220 Remove .impl_UNBOXED() and functionalities associated with it
Remove codegen logic to support non-c10-full ops #49164 Remove codegen logic to support non-c10-full ops
Making ops c10-full: list of optional tensors #49138 [wip] Making ops c10-full: list of optional tensors
Making ops c10-full: ConstQuantizerPtr #49150 Making ops c10-full: ConstQuantizerPtr
Making ops c10-full: Storage arguments #49146 Making ops c10-full: Storage arguments
Making ops c10-full: optional lists #49088 Making ops c10-full: optional lists
Making ops c10 full: optional out arguments #49083 Making ops c10 full: optional out arguments
Making ops c10-full: Generator arguments #49013 Making ops c10-full: Generator arguments
Making ops c10 full: out overloads with default arguments #49012 Making ops c10 full: out overloads with default arguments
Making ops c10-full: Dimname arguments #49008 Making ops c10-full: Dimname arguments
Making ops c10-full: ops blocked by manual registrations #49007 Making ops c10-full: ops blocked by manual registrations
Making ops c10 full: ops returning multiple out arguments #49006 Making ops c10 full: ops returning multiple out arguments
Make out ops c10-full (with hacky-wrapper) #48912 Make out ops c10-full (with hacky-wrapper)

Differential Revision: D25392590

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Pull Request resolved: #49008 ghstack-source-id: 118077898 Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/)

dr-ci · 2020-12-08T10:51:25Z

💊 CI failures summary and remediations

As of commit 2544992 (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Dec 15 18:45:44 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']

Dec 15 18:45:44 AtenXlaType function missed override: std::tuple<Tensor&, Tensor&> min_out(Tensor& min, Tensor& min_indices, const Tensor& self, int64_t dim, bool keepdim); // min_out(Tensor,Tensor,Tensor,int64_t,bool)->std::tuple<Tensor,Tensor>
Dec 15 18:45:44 Traceback (most recent call last):
Dec 15 18:45:44   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1172, in <module>
Dec 15 18:45:44     generate(args)
Dec 15 18:45:44   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1142, in generate
Dec 15 18:45:44     assert check_overrides(overrides, overridden)
Dec 15 18:45:44 AssertionError
Dec 15 18:45:44 Building torch_xla version: 1.6
Dec 15 18:45:44 XLA Commit ID: fe89172b2bd1c9a1c104bd2cbe565f30e6c8e328
Dec 15 18:45:44 PyTorch Commit ID: 0a063b68514cb03ec2e9b7f4e6e67f62e7c0a499
Dec 15 18:45:44 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']
Dec 15 18:45:45 + cleanup
Dec 15 18:45:45 + retcode=1
Dec 15 18:45:45 + set +x
Dec 15 18:45:45 =================== sccache compilation log ===================
Dec 15 18:45:45 =========== If your build fails, please take a look at the log above for possible reasons ===========
Dec 15 18:45:45 Compile requests                    4562
Dec 15 18:45:45 Compile requests executed           4268
Dec 15 18:45:45 Cache hits                          3249
Dec 15 18:45:45 Cache hits (C/C++)                  3249
Dec 15 18:45:45 Cache misses                        1001

XLA failure

Job pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by `[PT_BREAK]` in `pytorch/xla` and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 90 times.

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

facebook-github-bot · 2020-12-15T19:22:26Z

This pull request has been merged in b47fa5e.

Making ops c10-full: Dimname arguments

e7658a4

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

facebook-github-bot added the cla signed label Dec 8, 2020

smessmer mentioned this pull request Dec 8, 2020

Gaps for making template-unboxing work for all operators #32366

Closed

24 tasks

Update on "Making ops c10-full: Dimname arguments"

9838e66

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

1015140

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

smessmer added a commit that referenced this pull request Dec 8, 2020

Making ops c10-full: Dimname arguments

0a676bc

Pull Request resolved: #49008 ghstack-source-id: 118077898 Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/)

This was referenced Dec 8, 2020

Making ops c10 full: out overloads with default arguments #49012

Closed

Making ops c10-full: Generator arguments #49013

Closed

smessmer requested review from bhosmer and ezyang December 8, 2020 13:43

Update on "Making ops c10-full: Dimname arguments"

d616c55

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

ezyang approved these changes Dec 8, 2020

View reviewed changes

Update on "Making ops c10-full: Dimname arguments"

8200889

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

bhosmer approved these changes Dec 9, 2020

View reviewed changes

Update on "Making ops c10-full: Dimname arguments"

6046d0c

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

This was referenced Dec 9, 2020

remove hacky_wrapper from BackendSelect #49079

Closed

Making ops c10 full: optional out arguments #49083

Closed

Update on "Making ops c10-full: Dimname arguments"

ba5b593

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 9, 2020

Making ops c10-full: optional lists #49088

Closed

smessmer added 3 commits December 9, 2020 19:03

Update on "Making ops c10-full: Dimname arguments"

d63777a

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

c0a8479

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

9c2bd78

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 10, 2020

Making ops c10-full: list of optional tensors #49138

Closed

Update on "Making ops c10-full: Dimname arguments"

a01fbf0

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

This was referenced Dec 10, 2020

Making ops c10-full: Storage arguments #49146

Closed

Making ops c10-full: ConstQuantizerPtr #49150

Closed

smessmer added 2 commits December 9, 2020 23:17

Update on "Making ops c10-full: Dimname arguments"

a044348

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

966d3f5

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 10, 2020

Remove codegen logic to support non-c10-full ops #49164

Closed

smessmer added 4 commits December 10, 2020 11:18

Update on "Making ops c10-full: Dimname arguments"

f15b5e5

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

b8a82d5

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

9bfb64c

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

94d08ba

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

smessmer mentioned this pull request Dec 11, 2020

Remove .impl_UNBOXED() and functionalities associated with it #49220

Closed

smessmer added 3 commits December 11, 2020 03:54

Update on "Making ops c10-full: Dimname arguments"

e7ae278

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

73807e2

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

70d886e

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

This was referenced Dec 11, 2020

Remove generated_unboxing_wrappers and setManuallyBoxedKernel #49251

Closed

Remove use_c10_dispatcher: full lines #49259

Closed

smessmer added 2 commits December 12, 2020 02:23

Update on "Making ops c10-full: Dimname arguments"

0ee8eb9

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

Update on "Making ops c10-full: Dimname arguments"

2544992

Differential Revision: [D25392590](https://our.internmc.facebook.com/intern/diff/D25392590/) [ghstack-poisoned]

facebook-github-bot closed this in b47fa5e Dec 15, 2020

facebook-github-bot added the Merged label Dec 15, 2020

facebook-github-bot deleted the gh/smessmer/275/head branch December 19, 2020 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Making ops c10-full: Dimname arguments#49008

Making ops c10-full: Dimname arguments#49008
smessmer wants to merge 22 commits intogh/smessmer/275/basefrom
gh/smessmer/275/head

smessmer commented Dec 8, 2020 •

edited

Loading

Uh oh!

dr-ci bot commented Dec 8, 2020 •

edited by facebook-github-bot

Loading

Uh oh!

facebook-github-bot commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

smessmer commented Dec 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci bot commented Dec 8, 2020 • edited by facebook-github-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

XLA failure

Job pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

Uh oh!

facebook-github-bot commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smessmer commented Dec 8, 2020 •

edited

Loading

dr-ci bot commented Dec 8, 2020 •

edited by facebook-github-bot

Loading

Job pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by `[PT_BREAK]` in `pytorch/xla` and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.