Make aten::div.out c10-full#47793
Closed
smessmer wants to merge 13 commits intogh/smessmer/269/basefrom
Closed
Conversation
This migrates aten::div.out to be c10-full (without hacky wrapper) and fixes everything that needed to be fixed to make it work. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This was referenced Nov 11, 2020
smessmer
added a commit
that referenced
this pull request
Nov 11, 2020
This migrates aten::div.out to be c10-full (without hacky wrapper) and fixes everything that needed to be fixed to make it work. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) ghstack-source-id: 116457767 Pull Request resolved: #47793
💊 CI failures summary and remediationsAs of commit aab96da (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 84 times. |
This migrates aten::div.out to be c10-full (without hacky wrapper) and fixes everything that needed to be fixed to make it work and wasn't fixed in previous PRs yet. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 4, 2020
Pull Request resolved: #47793 This migrates aten::div.out to be c10-full (without hacky wrapper) and fixes everything that needed to be fixed to make it work. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. ghstack-source-id: 117830733 Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/)
This migrates aten::div.out to be c10-full (without hacky wrapper) and fixes everything that needed to be fixed to make it work and wasn't fixed in previous PRs yet. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 5, 2020
Pull Request resolved: #47793 This migrates aten::div.out to be c10-full (without hacky wrapper) and fixes everything that needed to be fixed to make it work. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. ghstack-source-id: 117923864 Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/)
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Dec 6, 2020
Pull Request resolved: #47793 This migrates aten::div.out to be c10-full (without hacky wrapper) and fixes everything that needed to be fixed to make it work. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. ghstack-source-id: 117963757 Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/)
This was referenced Dec 7, 2020
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This was referenced Dec 8, 2020
This was referenced Dec 8, 2020
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
bhosmer
approved these changes
Dec 8, 2020
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This was referenced Dec 9, 2020
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
This was referenced Dec 10, 2020
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this. This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full. Differential Revision: [D24901944](https://our.internmc.facebook.com/intern/diff/D24901944/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 21dba8c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This migrates aten::div.out to be c10-full (without hacky wrapper) as a proof of concept. This became possible after the PRs stacked below this.
This is a prerequisite step to making out ops c10-full. Diffs stacked on top of this will introduce a hacky_wrapper for out ops and use it to make more ops c10-full.
Differential Revision: D24901944