Enable faithful API for all ops#47711
Closed
smessmer wants to merge 3 commits intogh/smessmer/266/basefrom
Closed
Conversation
Seems we generated the declaration but the definition only for c10-full ops. We should also generate the definition for non-c10-full ops. This makes future migrations of ops from non-c10-full to c10-full have a lower impact on the C++ API. Differential Revision: [D24835006](https://our.internmc.facebook.com/intern/diff/D24835006/) [ghstack-poisoned]
This was referenced Nov 10, 2020
💊 CI failures summary and remediationsAs of commit e5c95bc (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 4 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
This was referenced Nov 11, 2020
bhosmer
approved these changes
Nov 11, 2020
Seems we generated the declaration but the definition only for c10-full ops. We should also generate the definition for non-c10-full ops. This makes future migrations of ops from non-c10-full to c10-full have a lower impact on the C++ API. Differential Revision: [D24835006](https://our.internmc.facebook.com/intern/diff/D24835006/) [ghstack-poisoned]
This was referenced Dec 7, 2020
Seems we generated the declaration but the definition only for c10-full ops. We should also generate the definition for non-c10-full ops. This makes future migrations of ops from non-c10-full to c10-full have a lower impact on the C++ API. Differential Revision: [D24835006](https://our.internmc.facebook.com/intern/diff/D24835006/) [ghstack-poisoned]
This was referenced Dec 8, 2020
Contributor
|
This pull request has been merged in 046ea66. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Seems we generated the declaration but the definition only for c10-full ops. We should also generate the definition for non-c10-full ops.
This makes future migrations of ops from non-c10-full to c10-full have a lower impact on the C++ API.
Differential Revision: D24835006