VariableType calls faithful C++ API for c10-full out ops#47792
Closed
smessmer wants to merge 9 commits intogh/smessmer/268/basefrom
Closed
VariableType calls faithful C++ API for c10-full out ops#47792smessmer wants to merge 9 commits intogh/smessmer/268/basefrom
smessmer wants to merge 9 commits intogh/smessmer/268/basefrom
Conversation
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
This was referenced Nov 11, 2020
💊 CI failures summary and remediationsAs of commit c250c26 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 4 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
This was referenced Dec 7, 2020
ezyang
reviewed
Dec 7, 2020
ezyang
approved these changes
Dec 7, 2020
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had. We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead. Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment. So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full. Differential Revision: [D24901945](https://our.internmc.facebook.com/intern/diff/D24901945/) [ghstack-poisoned]
This was referenced Dec 8, 2020
Contributor
|
This pull request has been merged in b643dbb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
For operators with out arguments, VariableType previously called the out overload of the C++ API because that's all we had.
We introduced a faithful C++ API that takes out arguments in schema-order in D24835252 and this PR changes VariableType to use that API instead.
Note that this only applies to c10-full ops. Non-c10-full ops still call the unfaithful API. There aren't any c10-full out ops at the moment.
So this PR can only be tested and evaluated together with PRs on top that make ops with out arguments c10-full.
Differential Revision: D24901945