Skip to content

Commit 046ea66

Browse files
smessmerfacebook-github-bot
authored andcommitted
Enable faithful API for all ops (#47711)
Summary: Pull Request resolved: #47711 Seems we generated the declaration but the definition only for c10-full ops. We should also generate the definition for non-c10-full ops. This makes future migrations of ops from non-c10-full to c10-full have a lower impact on the C++ API. ghstack-source-id: 118064755 Test Plan: waitforsandcastle Reviewed By: bhosmer Differential Revision: D24835006 fbshipit-source-id: 8f5c3c0ffcdc9b479ca3785d57da16db508795f5
1 parent 32b098b commit 046ea66

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

tools/codegen/gen.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,8 +480,7 @@ def generate_defn(sig: CppSignature) -> str:
480480

481481
result = generate_defn(sig_group.signature)
482482
if sig_group.faithful_signature is not None:
483-
if local.use_c10_dispatcher().dispatcher_uses_new_style():
484-
result += generate_defn(sig_group.faithful_signature)
483+
result += generate_defn(sig_group.faithful_signature)
485484

486485
return result
487486

0 commit comments

Comments
 (0)