Skip to content

[jit][subgraph_rewriter] Support list of filters#39867

Closed
jerryzh168 wants to merge 10 commits intogh/jerryzh168/341/basefrom
gh/jerryzh168/341/head
Closed

[jit][subgraph_rewriter] Support list of filters#39867
jerryzh168 wants to merge 10 commits intogh/jerryzh168/341/basefrom
gh/jerryzh168/341/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Jun 11, 2020 •
edited
Loading

Stack from ghstack:

Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D22009855

@jerryzh168
[jit][subgraph_rewriter] Support list of filters
9ad9b6b 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner June 11, 2020 17:01
This was referenced Jun 11, 2020
Closed
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 11, 2020
@jerryzh168 jerryzh168 requested a review from ZolotukhinM June 11, 2020 17:02
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
358a0bf 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jun 11, 2020
@jerryzh168
[jit][subgraph_rewriter] Support list of filters
42e5dcf 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: b68af35
Pull Request resolved: #39867
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 11, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit e5e6907 (more details on the Dr. CI page):

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

Extra GitHub checks: 1 failed

ci.pytorch.org: 2 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 38 times.

ZolotukhinM
ZolotukhinM approved these changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
e257c53 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jun 11, 2020
Closed
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
733077f 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Jun 11, 2020
Closed
Closed
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
5f14c45 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22009855](https://our.internmc.facebook.com/intern/diff/D22009855)

[ghstack-poisoned]
This was referenced Jun 12, 2020
Closed
Closed
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
d2e958f 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22009855](https://our.internmc.facebook.com/intern/diff/D22009855)

[ghstack-poisoned]
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
3d05ec8 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22009855](https://our.internmc.facebook.com/intern/diff/D22009855)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jun 12, 2020
Closed
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
41f9e87 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22009855](https://our.internmc.facebook.com/intern/diff/D22009855)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jun 12, 2020
Closed
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
c0e4c64 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22009855](https://our.internmc.facebook.com/intern/diff/D22009855)

[ghstack-poisoned]
@jerryzh168
Update on "[jit][subgraph_rewriter] Support list of filters"
e5e6907 
Summary:
Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22009855](https://our.internmc.facebook.com/intern/diff/D22009855)

[ghstack-poisoned]
This was referenced Jun 12, 2020
Closed
Closed
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 12, 2020

This pull request has been merged in 004aa08.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/341/head branch June 16, 2020 15:19
xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
@jerryzh168 @xwang233
[jit][subgraph_rewriter] Support list of filters (pytorch#39867)
9041086 
Summary:
Pull Request resolved: pytorch#39867

Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan: Imported from OSS

Differential Revision: D22009855

fbshipit-source-id: 67aab8d6326b2011a9061397699dc62ee9ad4e2d
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[jit][subgraph_rewriter] Support list of filters (pytorch#39867)
d6862b0 
Summary:
Pull Request resolved: pytorch#39867

Support list of filters in subgraph rewriter, the rewrite will execute only
when the match passes all filter check. this is useful for different matches
to share the same filter.

Test Plan: Imported from OSS

Differential Revision: D22009855

fbshipit-source-id: 67aab8d6326b2011a9061397699dc62ee9ad4e2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

1 more reviewer

@ZolotukhinM ZolotukhinM ZolotukhinM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @ZolotukhinM @mruberry