[quant][graphmode] Run RemoveRedundantDequantize in the end#39923
Closed
jerryzh168 wants to merge 3 commits intogh/jerryzh168/349/basefrom
Closed
[quant][graphmode] Run RemoveRedundantDequantize in the end#39923jerryzh168 wants to merge 3 commits intogh/jerryzh168/349/basefrom
jerryzh168 wants to merge 3 commits intogh/jerryzh168/349/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 12, 2020
This was referenced Jun 12, 2020
💊 CI failures summary and remediationsAs of commit b17af0e (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22014712](https://our.internmc.facebook.com/intern/diff/D22014712) [ghstack-poisoned]
vkuzo
approved these changes
Jun 15, 2020
Contributor
vkuzo
left a comment
There was a problem hiding this comment.
lg, would be awesome if we also had some context on the "why" (for new team members to learn)
Contributor
Author
sure, updated summary |
Summary: `propagateQuantizationOps` generate new `dequantize` ops, so this pass should run after that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22014712](https://our.internmc.facebook.com/intern/diff/D22014712) [ghstack-poisoned]
Contributor
|
This pull request has been merged in b372000. |
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
…39923) Summary: Pull Request resolved: pytorch#39923 Test Plan: Imported from OSS Differential Revision: D22014712 fbshipit-source-id: a681bbab5d90ac8ebeff03cde5277501e86ee1d4
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…39923) Summary: Pull Request resolved: pytorch#39923 Test Plan: Imported from OSS Differential Revision: D22014712 fbshipit-source-id: a681bbab5d90ac8ebeff03cde5277501e86ee1d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
repeat#39925 [quant][graphmode] Support quantizingrepeatSummary:
propagateQuantizationOpsgenerate newdequantizeops, so this pass should run after that.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D22014712