[quant][graphmode] Support prim::TupleUnpack and prim::TupleConstruct#39895
Closed
jerryzh168 wants to merge 9 commits intogh/jerryzh168/344/basefrom
Closed
[quant][graphmode] Support prim::TupleUnpack and prim::TupleConstruct#39895jerryzh168 wants to merge 9 commits intogh/jerryzh168/344/basefrom
jerryzh168 wants to merge 9 commits intogh/jerryzh168/344/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 11, 2020
💊 CI failures summary and remediationsAs of commit b317440 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 25 times. |
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
This was referenced Jun 12, 2020
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
| } | ||
| return inputs; | ||
| } else if (n->kind() == prim::ListUnpack) { | ||
| } else if (n->kind() == prim::ListUnpack || n->kind() == prim::TupleUnpack) { |
Contributor
There was a problem hiding this comment.
Can you explain why you return input(0) here?
Contributor
Author
There was a problem hiding this comment.
input(0) is the input of the list unpack/ tuple unpack. which is a list/tuple. this function is to propagate observed property from input to output, in this case we can propagate the observed property from the list/tuple to their output, which are the unpacked values.
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
This was referenced Jun 12, 2020
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
…leConstruct" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22009854](https://our.internmc.facebook.com/intern/diff/D22009854) [ghstack-poisoned]
Contributor
|
This pull request has been merged in f37b8e7. |
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
…ytorch#39895) Summary: Pull Request resolved: pytorch#39895 Test Plan: Imported from OSS Differential Revision: D22009854 fbshipit-source-id: a5dab2b4f943e5e047ba9e8573088adf66f5da6b
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#39895) Summary: Pull Request resolved: pytorch#39895 Test Plan: Imported from OSS Differential Revision: D22009854 fbshipit-source-id: a5dab2b4f943e5e047ba9e8573088adf66f5da6b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
repeat#39925 [quant][graphmode] Support quantizingrepeatSummary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D22009854