Skip to content

[quant] Support general op modules with inplace options#39919

Closed
jerryzh168 wants to merge 6 commits intogh/jerryzh168/348/basefrom
gh/jerryzh168/348/head
Closed

[quant] Support general op modules with inplace options#39919
jerryzh168 wants to merge 6 commits intogh/jerryzh168/348/basefrom
gh/jerryzh168/348/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Jun 12, 2020

Stack from ghstack:

Summary:
e.g. torch.nn.ReLU6(inplace=True)
looks like this is already supported, but somehow it is not working in tutorial

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D22055695

Summary:
e.g. torch.nn.ReLU6(inplace=True)

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 12, 2020

💊 CI failures summary and remediations

As of commit 3c27969 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 19 times.

Summary:
e.g. torch.nn.ReLU6(inplace=True)

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:
e.g. torch.nn.ReLU6(inplace=True)

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:
e.g. torch.nn.ReLU6(inplace=True)

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jun 12, 2020
Summary:
e.g. torch.nn.ReLU6(inplace=True)

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 98b3ba9
Pull Request resolved: #39919
@jerryzh168 jerryzh168 changed the title [wip][quant] Support general op modules with inplace options [quant] Support general op modules with inplace options Jun 15, 2020
Summary:
e.g. torch.nn.ReLU6(inplace=True)
looks like this is already supported, but somehow it is not working in tutorial

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:
e.g. torch.nn.ReLU6(inplace=True)
looks like this is already supported, but somehow it is not working in tutorial

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 41fa4be.

xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
Summary:
Pull Request resolved: pytorch#39919

e.g. torch.nn.ReLU6(inplace=True)
looks like this is already supported, but somehow it is not working in tutorial

Test Plan: Imported from OSS

Differential Revision: D22055695

fbshipit-source-id: 78a55b963cd3fac06f952f83c7c61c717cc839cc
@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/348/head branch June 20, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#39919

e.g. torch.nn.ReLU6(inplace=True)
looks like this is already supported, but somehow it is not working in tutorial

Test Plan: Imported from OSS

Differential Revision: D22055695

fbshipit-source-id: 78a55b963cd3fac06f952f83c7c61c717cc839cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants