Skip to content

[quant][graphmode] Use quantized::batch_norm in graph mode#39911

Closed
jerryzh168 wants to merge 9 commits intogh/jerryzh168/346/basefrom
gh/jerryzh168/346/head
Closed

[quant][graphmode] Use quantized::batch_norm in graph mode#39911
jerryzh168 wants to merge 9 commits intogh/jerryzh168/346/basefrom
gh/jerryzh168/346/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Jun 12, 2020 •
edited
Loading

Stack from ghstack:

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D22012282

@jerryzh168
[quant][graphmode] Use quantized::batch_norm in graph mode
8c2e9f4 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner June 12, 2020 01:03
This was referenced Jun 12, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 12, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 12, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 361fa86 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_bazel_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

Jun 15 23:14:41 TIMEOUT: //:integration_test (Summary) 
Jun 15 23:14:41 ==================== Test output for //:integration_test: 
Jun 15 23:14:41 Running main() from gmock_main.cc 
Jun 15 23:14:41 Note: Google Test filter = -*CUDA 
Jun 15 23:14:41 [==========] Running 1 test from 1 test suite. 
Jun 15 23:14:41 [----------] Global test environment set-up. 
Jun 15 23:14:41 [----------] 1 test from IntegrationTest 
Jun 15 23:14:41 [ RUN      ] IntegrationTest.CartPole 
Jun 15 23:14:41 -- Test timed out at 2020-06-15 23:14:26 UTC -- 
Jun 15 23:14:41 ================================================================================ 
Jun 15 23:14:41  
Jun 15 23:14:41 TIMEOUT: //:integration_test (Summary) 
Jun 15 23:14:41       /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/execroot/pytorch/bazel-out/k8-fastbuild/testlogs/integration_test/test.log 
Jun 15 23:14:41 INFO: From Testing //:integration_test: 
Jun 15 23:14:41 INFO: Elapsed time: 464.379s, Critical Path: 328.87s 
Jun 15 23:14:41 INFO: 207 processes: 207 processwrapper-sandbox. 
Jun 15 23:14:41 INFO: Build completed, 1 test FAILED, 339 total actions 
Jun 15 23:14:41 //:any_test                                                              PASSED in 1.2s 
Jun 15 23:14:41 //:autograd_test                                                         PASSED in 9.9s 
Jun 15 23:14:41 //:c10_tests                                                             PASSED in 0.9s 
Jun 15 23:14:41 //:dataloader_test                                                       PASSED in 1.3s 
Jun 15 23:14:41 //:enum_test                                                             PASSED in 1.1s
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 30 times.

@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
44d9255 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jun 12, 2020
@jerryzh168
[quant][graphmode] Use quantized::batch_norm in graph mode
000d5e3 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 08a407d
Pull Request resolved: #39911
@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
b88b13a 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jun 12, 2020
Closed
@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
df5ff53 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
6d13a4f 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jun 12, 2020
Closed
@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
6545074 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
524cad6 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
This was referenced Jun 12, 2020
Closed
Closed
Closed
@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
3fab50a 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jun 15, 2020
Closed
vkuzo
vkuzo approved these changes Jun 15, 2020
View reviewed changes
Comment thread torch/csrc/jit/passes/quantization/insert_observers.cpp
inplace_add_aten_relu, inplace_add_aten_relu_,
nn_bn_nn_relu, nn_bn_f_relu,
nn_bn_aten_relu, nn_bn_aten_relu_,
nn_bn2d_nn_relu, nn_bn2d_f_relu,
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we adding bn1d later?

Copy link
Copy Markdown
Contributor Author

@jerryzh168 jerryzh168 Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is used by user then we should implement them. right now we don't have plans to do that

Copy link
Copy Markdown
Contributor Author

@jerryzh168 jerryzh168 Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now quantized::batch_norm1d is not implemented

@jerryzh168
Update on "[quant][graphmode] Use quantized::batch_norm in graph mode"
361fa86 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22012282](https://our.internmc.facebook.com/intern/diff/D22012282)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 16, 2020

This pull request has been merged in 144e8dc.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/346/head branch June 19, 2020 14:16
xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
@jerryzh168 @xwang233
[quant][graphmode] Use quantizedbatch_norm in graph mode (pytorch#39911)
b1c96a6 
Summary: Pull Request resolved: pytorch#39911

Test Plan: Imported from OSS

Differential Revision: D22012282

fbshipit-source-id: 98af55172cbeaa7080865d6533df21647a7cedfa
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode] Use quantizedbatch_norm in graph mode (pytorch#39911)
373559d 
Summary: Pull Request resolved: pytorch#39911

Test Plan: Imported from OSS

Differential Revision: D22012282

fbshipit-source-id: 98af55172cbeaa7080865d6533df21647a7cedfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @vkuzo @mruberry