[quant][graphmode] Remove dedup pass#39825
Closed
jerryzh168 wants to merge 8 commits intogh/jerryzh168/339/basefrom
Closed
[quant][graphmode] Remove dedup pass#39825jerryzh168 wants to merge 8 commits intogh/jerryzh168/339/basefrom
jerryzh168 wants to merge 8 commits intogh/jerryzh168/339/basefrom
Conversation
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 10, 2020
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 980ad71 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 21 times. |
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21987878](https://our.internmc.facebook.com/intern/diff/D21987878) [ghstack-poisoned]
| if not all(isinstance(x, str) for x in qconfig_dict.keys()): | ||
| raise ValueError('qconfig_dict should only contain names(str) as keys.') | ||
| scripted_qconfig_dict = script_qconfig_dict(qconfig_dict) | ||
| torch._C._jit_pass_dedup_module_uses(model._c) |
Contributor
There was a problem hiding this comment.
Dont you need to remove the corresponding tests?
I thought this pass was needed to handle cases like:
- x = self.conv1(x)
- x = self.relu(x)
- x = self.conv2(x)
- x = self.relu(x)
Contributor
Author
There was a problem hiding this comment.
this is a legacy pass we added for this case, but this case can be addressed with current code already. I feel this pass might not be needed if we have some (unlikely) case like:
x = self.submodule_with_states(x)
...
x = self.submodule_with_states(x)that is: we use some submodule with states multiple times.
I only removed this from API, this pass is still there. If we decide to support the above use case at some point, we'll debug the problem and re-enable the pass.
supriyar
approved these changes
Jun 11, 2020
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21987878](https://our.internmc.facebook.com/intern/diff/D21987878) [ghstack-poisoned]
This was referenced Jun 11, 2020
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21987878](https://our.internmc.facebook.com/intern/diff/D21987878) [ghstack-poisoned]
This was referenced Jun 12, 2020
raghuramank100
approved these changes
Jun 12, 2020
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21987878](https://our.internmc.facebook.com/intern/diff/D21987878) [ghstack-poisoned]
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21987878](https://our.internmc.facebook.com/intern/diff/D21987878) [ghstack-poisoned]
Summary: Removing the pass for now since it is causing error for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21987878](https://our.internmc.facebook.com/intern/diff/D21987878) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 14e841c. |
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
Summary: Pull Request resolved: pytorch#39825 Removing the pass for now since it is causing error for some models Test Plan: Imported from OSS Differential Revision: D21987878 fbshipit-source-id: 129aefb34754d5390a4c9d3108fa1b6c2eae5a74
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#39825 Removing the pass for now since it is causing error for some models Test Plan: Imported from OSS Differential Revision: D21987878 fbshipit-source-id: 129aefb34754d5390a4c9d3108fa1b6c2eae5a74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Removing the pass for now since it is causing error for some models
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21987878