Skip to content

Update internal invariants in the world of manuallyBoxedKernel#36388

Closed
ezyang wants to merge 6 commits intogh/ezyang/714/basefrom
gh/ezyang/714/head
Closed

Update internal invariants in the world of manuallyBoxedKernel#36388
ezyang wants to merge 6 commits intogh/ezyang/714/basefrom
gh/ezyang/714/head

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Apr 10, 2020

Stack from ghstack:

(This wants to make me barf).

Signed-off-by: Edward Z. Yang ezyang@fb.com

Differential Revision: D20964195

(This wants to make me barf).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 10, 2020

💊 Build failures summary and remediations

As of commit 7e19d6c (more details on the Dr. CI page):


  • 6/6 failures possibly* introduced in this PR
    • 6/6 non-CircleCI failure(s)

Extra GitHub checks


ci.pytorch.org


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 14 times.

@ezyang ezyang requested a review from smessmer April 10, 2020 14:33
Copy link
Copy Markdown
Contributor

@smessmer smessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. We should probably do this in OperatorEntry::setManuallyBoxedKernel_ though and not in OperatorEntry::checkInvariants.

Copy link
Copy Markdown
Contributor

@smessmer smessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock fix

ezyang added 2 commits April 10, 2020 11:20
…rnel"

(This wants to make me barf).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195)

[ghstack-poisoned]
…rnel"

(This wants to make me barf).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195)

[ghstack-poisoned]
ezyang added 2 commits April 13, 2020 14:07
…rnel"

(This wants to make me barf).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195)

[ghstack-poisoned]
…rnel"

(This wants to make me barf).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195)

[ghstack-poisoned]
…rnel"

(This wants to make me barf).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ezyang merged this pull request in 8f501f3.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/714/head branch April 17, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…ch#36388)

Summary:
Pull Request resolved: pytorch#36388

(This wants to make me barf).

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Differential Revision: D20964195

Pulled By: ezyang

fbshipit-source-id: 3699a02b16060d79dae9890bafeaafad9ad9ae60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants