Update internal invariants in the world of manuallyBoxedKernel#36388
Closed
ezyang wants to merge 6 commits intogh/ezyang/714/basefrom
Closed
Update internal invariants in the world of manuallyBoxedKernel#36388ezyang wants to merge 6 commits intogh/ezyang/714/basefrom
ezyang wants to merge 6 commits intogh/ezyang/714/basefrom
Conversation
(This wants to make me barf). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Apr 10, 2020
💊 Build failures summary and remediationsAs of commit 7e19d6c (more details on the Dr. CI page):
Extra GitHub checks
ci.pytorch.orgThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 14 times. |
smessmer
requested changes
Apr 10, 2020
Contributor
smessmer
left a comment
There was a problem hiding this comment.
Thanks for fixing this. We should probably do this in OperatorEntry::setManuallyBoxedKernel_ though and not in OperatorEntry::checkInvariants.
smessmer
approved these changes
Apr 10, 2020
Contributor
smessmer
left a comment
There was a problem hiding this comment.
approving to unblock fix
…rnel" (This wants to make me barf). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195) [ghstack-poisoned]
…rnel" (This wants to make me barf). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195) [ghstack-poisoned]
This was referenced Apr 13, 2020
…rnel" (This wants to make me barf). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195) [ghstack-poisoned]
…rnel" (This wants to make me barf). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195) [ghstack-poisoned]
This was referenced Apr 13, 2020
…rnel" (This wants to make me barf). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964195](https://our.internmc.facebook.com/intern/diff/D20964195) [ghstack-poisoned]
This was referenced Apr 13, 2020
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ch#36388) Summary: Pull Request resolved: pytorch#36388 (This wants to make me barf). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D20964195 Pulled By: ezyang fbshipit-source-id: 3699a02b16060d79dae9890bafeaafad9ad9ae60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
(This wants to make me barf).
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D20964195