Port to new registration API (part 1) by ezyang · Pull Request #36389 · pytorch/pytorch

ezyang · 2020-04-10T14:32:09Z

Stack from ghstack:

Put TORCH_LIBRARY in torch/library.h; add custom class API #36742 Add custom class API to TORCH_LIBRARY API.
Port to new registration API (part 1) #36389 Port to new registration API (part 1)

This is a roll up of a bunch of small PRs for ease of landing.

Update reference to RegisterOperators in error message in Convolution. Port to new registration API (part 1) #36389
Port Resize to use new registration API. Port Resize to use new registration API. #36390
Port detach/detach to new registration API. Port detach/detach to new registration API #36512
Add explicit schema for quantized conv/conv_prepack (fixes quantized::conv2d and variants don't have explicit schema #36511). Add explicit schema for quantized conv/conv_prepack #36513
Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes Meaning of _quantized namespace isn't documented #36510). Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops. #36520
Functionalize qadd and register with new registration API. Functionalize qadd and register with new registration API. #36527
Update quantized README for registering operators with new API. Update quantized README for registering operators with new API. #36531
Convert qbatch_norm to new operator registration API. Convert qbatch_norm to new operator registration API. #36534
Convert qclamp to new operator registration API. Convert qclamp to new operator registration API. #36535
Functionalize qconcat and register with new registration API. Functionalize qconcat and register with new registration API #36536

Differential Revision: D20964193

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

dr-ci · 2020-04-10T14:44:29Z

💊 Build failures summary and remediations

As of commit 388f0c0 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 74 times.

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: a99e00b Pull Request resolved: pytorch#36389

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 ghstack-source-id: fe27bc1 Pull Request resolved: #36389

This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

dzhulgakov · 2020-04-16T20:54:07Z

    ('quantized::batch_norm', datetime.date(2020, 4, 20)),
    ('aten::sizes', datetime.date(2020, 4, 30)),
    ('aten::strides', datetime.date(2020, 4, 30)),
+    ('quantized::conv_prepack', datetime.date(2020, 6, 1)),


what's going on here? why do you need to put it into BC test?

~~Oh, this is mistake from when I typoed conv_prepack for an registration, and that lit up the bc check, and then when I fixed the typo I didn't fix the registration~~

I need this in the BC test because I made a (technical) BC breaking change.

Previously, conv_prepack was registered with inferred schema:

- .op("quantized::conv_prepack", // conv_prepack is deprecated, please use - // conv2d_prepack for 2D conv.

With this PR, it is now done with explicit schema:

+ // conv_prepack is deprecated, please use conv2d_prepack for 2D conv. + m.def("conv_prepack(Tensor weight, Tensor? bias, int[] stride, int[] padding, int[] dilation, int groups) -> Tensor");

Moving from implicit to explicit is considered bc breaking by the bc script, thus I must whitelist it.

kostmo · 2020-04-17T00:46:49Z

Appears to have caused the following in master:

Apr 17 00:15:27 ======================================================================
Apr 17 00:15:27 ERROR [0.374s]: test_batch_norm2d (__main__.TestQuantizedOps)
Apr 17 00:15:27 ----------------------------------------------------------------------
Apr 17 00:15:27 Traceback (most recent call last):
Apr 17 00:15:27   File "quantization/test_quantized.py", line 1534, in test_batch_norm2d
Apr 17 00:15:27     min_side=1, max_side=32),
Apr 17 00:15:27   File "/var/lib/jenkins/.local/lib/python3.7/site-packages/hypothesis/core.py", line 1116, in wrapped_test
Apr 17 00:15:27     raise the_error_hypothesis_found
Apr 17 00:15:27   File "quantization/test_quantized.py", line 1554, in test_batch_norm2d
Apr 17 00:15:27     qy = torch.ops.quantized.batch_norm2d(qx, weight, bias, mean, var, eps, Y_scale, Y_zero_point)
Apr 17 00:15:27   File "/opt/python/nightly/lib/python3.7/site-packages/torch/_ops.py", line 61, in __getattr__
Apr 17 00:15:27     op = torch._C._jit_get_operation(qualified_op_name)

Reverting.

facebook-github-bot · 2020-04-17T02:22:23Z

@ezyang merged this pull request in 6615886.

ezyang · 2020-04-17T03:27:52Z

Stunning, the local ci was all green! XD

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: a99e00b Pull Request resolved: pytorch/pytorch#36389

…pytorch#36389) Summary: Pull Request resolved: pytorch#36389 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D20964193 Pulled By: ezyang fbshipit-source-id: 27aeea01ccf5dfcebb8f043cde009a14dde3958e

Update reference to RegisterOperators in error message in Convolution

dfb1f1d

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

ezyang added 4 commits April 10, 2020 11:20

Update on "Update reference to RegisterOperators in error message in …

1c6354d

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

9d509b2

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

a5410d2

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

297d3e8

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

smessmer approved these changes Apr 13, 2020

View reviewed changes

This was referenced Apr 13, 2020

Make it an error to TORCH_LIBRARY the same namespace twice. #36505

Closed

Port detach/detach to new registration API #36512

Closed

Add explicit schema for quantized conv/conv_prepack #36513

Closed

ezyang added 3 commits April 13, 2020 14:07

Update on "Update reference to RegisterOperators in error message in …

a0943fb

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

9106717

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

8a26c7d

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

This was referenced Apr 13, 2020

Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops. #36520

Closed

Functionalize qadd and register with new registration API. #36527

Closed

Update on "Update reference to RegisterOperators in error message in …

1a49ded

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

68acd59

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

ljk53 pushed a commit to ljk53/pytorch that referenced this pull request Apr 14, 2020

Update reference to RegisterOperators in error message in Convolution

58b1c49

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: a99e00b Pull Request resolved: pytorch#36389

ezyang added 2 commits April 15, 2020 10:09

Update on "Update reference to RegisterOperators in error message in …

eb8dca3

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

5577b05

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

ezyang added 2 commits April 15, 2020 11:05

Update on "Update reference to RegisterOperators in error message in …

e862d8c

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

Update on "Update reference to RegisterOperators in error message in …

853868a

…Convolution" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]

ezyang changed the title ~~Update reference to RegisterOperators in error message in Convolution~~ Port to new registration API (part 1) Apr 16, 2020

ezyang mentioned this pull request Apr 16, 2020

Put TORCH_LIBRARY in torch/library.h; add custom class API #36742

Closed

dzhulgakov reviewed Apr 16, 2020

View reviewed changes

facebook-github-bot closed this in 6615886 Apr 16, 2020

facebook-github-bot added the merged label Apr 17, 2020

facebook-github-bot deleted the gh/ezyang/715/head branch April 20, 2020 14:17

okly366 pushed a commit to okly366/pytorch that referenced this pull request Apr 26, 2020

Update reference to RegisterOperators in error message in Convolution

e580ee3

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: a99e00b Pull Request resolved: pytorch/pytorch#36389

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port to new registration API (part 1)#36389

Port to new registration API (part 1)#36389
ezyang wants to merge 16 commits intogh/ezyang/715/basefrom
gh/ezyang/715/head

ezyang commented Apr 10, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented Apr 10, 2020 •

edited

Loading

Uh oh!

dzhulgakov Apr 16, 2020

Uh oh!

ezyang Apr 16, 2020 •

edited

Loading

Uh oh!

ezyang Apr 16, 2020

Uh oh!

kostmo commented Apr 17, 2020

Uh oh!

facebook-github-bot commented Apr 17, 2020

Uh oh!

ezyang commented Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ezyang commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 Build failures summary and remediations

Uh oh!

dzhulgakov Apr 16, 2020

Choose a reason for hiding this comment

Uh oh!

ezyang Apr 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ezyang Apr 16, 2020

Choose a reason for hiding this comment

Uh oh!

kostmo commented Apr 17, 2020

Uh oh!

facebook-github-bot commented Apr 17, 2020

Uh oh!

ezyang commented Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ezyang commented Apr 10, 2020 •

edited

Loading

dr-ci Bot commented Apr 10, 2020 •

edited

Loading

ezyang Apr 16, 2020 •

edited

Loading