Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops.#36520
Closed
ezyang wants to merge 7 commits intogh/ezyang/721/basefrom
Closed
Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops.#36520ezyang wants to merge 7 commits intogh/ezyang/721/basefrom
ezyang wants to merge 7 commits intogh/ezyang/721/basefrom
Conversation
… ops. Fixes #36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Apr 13, 2020
💊 Build failures summary and remediationsAs of commit 762b42b (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following build failures do not appear to be due to upstream breakages:
|
…and xnnpack ops." Fixes #36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Apr 13, 2020
…and xnnpack ops." Fixes #36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21005369](https://our.internmc.facebook.com/intern/diff/D21005369) [ghstack-poisoned]
kimishpatel
reviewed
Apr 14, 2020
| static auto linear_op_context_class = register_packed_linear_op_context_class(); | ||
| static auto conv2d_op_context_class = register_packed_conv2d_op_context_class(); | ||
|
|
||
| // TODO: These should probably be in an xnnpack namespace? |
Contributor
Contributor
Author
There was a problem hiding this comment.
thanks, I'll fix this
kimishpatel
requested changes
Apr 14, 2020
Contributor
kimishpatel
left a comment
There was a problem hiding this comment.
XNNPACK stuff looks fine to me. Note that namespace change comment I made. So you probably want to remove that TODO.
ljk53
pushed a commit
to ljk53/pytorch
that referenced
this pull request
Apr 14, 2020
… ops. Fixes pytorch#36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 585057c Pull Request resolved: pytorch#36520
Contributor
|
quantized op related changes looks good to me, although we have some in flight PRs but since the changes are small, it should be easy to merge |
…and xnnpack ops." Fixes #36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21005369](https://our.internmc.facebook.com/intern/diff/D21005369) [ghstack-poisoned]
…and xnnpack ops." Fixes #36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21005369](https://our.internmc.facebook.com/intern/diff/D21005369) [ghstack-poisoned]
…and xnnpack ops." Fixes #36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21005369](https://our.internmc.facebook.com/intern/diff/D21005369) [ghstack-poisoned]
…and xnnpack ops." Fixes #36510 Note that this introduces some schema string duplication, but I'll kill the dupes when I migrate the individual files to the new registration API. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21005369](https://our.internmc.facebook.com/intern/diff/D21005369) [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 16, 2020
This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 16, 2020
This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 16, 2020
This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 ghstack-source-id: fe27bc1 Pull Request resolved: #36389
Contributor
Author
|
This will be rolled up into #36389 |
ezyang
added a commit
that referenced
this pull request
Apr 16, 2020
This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 16, 2020
This is a roll up of a bunch of small PRs for ease of landing. - Update reference to RegisterOperators in error message in Convolution. #36389 - Port Resize to use new registration API. #36390 - Port detach/detach to new registration API. #36512 - Add explicit schema for quantized conv/conv_prepack (fixes #36511). #36513 - Add a centralized TORCH_LIBRARY declaration for quantized and xnnpack ops (fixes #36510). #36520 - Functionalize qadd and register with new registration API. #36527 - Update quantized README for registering operators with new API. #36531 - Convert qbatch_norm to new operator registration API. #36534 - Convert qclamp to new operator registration API. #36535 - Functionalize qconcat and register with new registration API. #36536 Differential Revision: [D20964193](https://our.internmc.facebook.com/intern/diff/D20964193) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #36510
Note that this introduces some schema string duplication, but I'll
kill the dupes when I migrate the individual files to the new
registration API.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D21005369