Unconditionally register schema even for manual registration.#36250
Closed
ezyang wants to merge 11 commits intogh/ezyang/709/basefrom
Closed
Unconditionally register schema even for manual registration.#36250ezyang wants to merge 11 commits intogh/ezyang/709/basefrom
ezyang wants to merge 11 commits intogh/ezyang/709/basefrom
Conversation
The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Apr 8, 2020
ezyang
added a commit
that referenced
this pull request
Apr 8, 2020
The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: cafa8a4 Pull Request resolved: #36250
💊 Build failures summary and remediationsAs of commit fc81e9b (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 upstream failure:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 32 times. |
This was referenced Apr 8, 2020
Closed
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
bhosmer
approved these changes
Apr 9, 2020
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
This was referenced Apr 10, 2020
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
smessmer
approved these changes
Apr 13, 2020
This was referenced Apr 13, 2020
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
This was referenced Apr 13, 2020
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
This was referenced Apr 13, 2020
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
ljk53
pushed a commit
to ljk53/pytorch
that referenced
this pull request
Apr 14, 2020
The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 2e89ed0 Pull Request resolved: pytorch#36250
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…h#36250) Summary: Pull Request resolved: pytorch#36250 The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D20929258 Pulled By: ezyang fbshipit-source-id: 0a9fdc8eccd7b688b3e7bd8ed64b6e2af21978f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The general concept is that I want a centralized location where you
can find all of the registrations for a library. I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself. Make it so.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D20929258