Remove (most) Python 2 support from Python code#35615
Closed
dreiss wants to merge 7 commits intogh/dreiss/32/basefrom
Closed
Remove (most) Python 2 support from Python code#35615dreiss wants to merge 7 commits intogh/dreiss/32/basefrom
dreiss wants to merge 7 commits intogh/dreiss/32/basefrom
Conversation
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI
💊 Build failures summary and remediationsAs of commit e049414 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 45 times. |
This was referenced Mar 28, 2020
Closed
ezyang
reviewed
Mar 30, 2020
| print(np.max(np.abs(Y2 - Y0))) | ||
| self.assertTrue(False) | ||
|
|
||
| @unittest.skipIf(sys.version_info.major > 2, "broken in python 3") |
Contributor
There was a problem hiding this comment.
Probably shouldn't delete this, just mark it as expected broken or something? Or maybe the code is moribund and we don't care anyway... I guess probably that is true.
ezyang
reviewed
Mar 30, 2020
|
|
||
| if not PY2: | ||
| ops.append(truediv) | ||
| ops.append(truediv) |
Contributor
There was a problem hiding this comment.
nit: can be moved to the list (don't do it in this PR if everything else is ok)
ezyang
reviewed
Mar 30, 2020
| from torch.testing._internal.common_utils import TEST_WITH_ROCM, shell | ||
| import torch.distributed as dist | ||
| PY2 = sys.version_info <= (3,) | ||
| PY33 = sys.version_info >= (3, 3) |
Contributor
There was a problem hiding this comment.
We can probably axe this one too
ezyang
reviewed
Mar 30, 2020
| self.assertExpected(str(ast)) | ||
|
|
||
| @unittest.skipIf(PY2, "Requires python 3") | ||
| def test_python_frontend_py3(self): |
Contributor
There was a problem hiding this comment.
nit: should probably rename the test, but whatever
ezyang
reviewed
Mar 30, 2020
| except ImportError: | ||
| return False | ||
| elif not PY34: # Python [3, 3.4) | ||
| if not PY34: # Python [3, 3.4) |
Contributor
There was a problem hiding this comment.
Probably can get rid of this one (we don't support 3.4)
Contributor
Author
There was a problem hiding this comment.
Would you be comfortable with me adding a check like #35611 for 3.5+?
ezyang
approved these changes
Mar 30, 2020
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI Differential Revision: [D20842886](https://our.internmc.facebook.com/intern/diff/D20842886)
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI Differential Revision: [D20842886](https://our.internmc.facebook.com/intern/diff/D20842886)
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI Differential Revision: [D20842886](https://our.internmc.facebook.com/intern/diff/D20842886) [ghstack-poisoned]
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI Differential Revision: [D20842886](https://our.internmc.facebook.com/intern/diff/D20842886) [ghstack-poisoned]
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI Differential Revision: [D20842886](https://our.internmc.facebook.com/intern/diff/D20842886) [ghstack-poisoned]
Contributor
okly366
pushed a commit
to okly366/pytorch
that referenced
this pull request
Apr 26, 2020
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI ghstack-source-id: c491b81 Pull Request resolved: pytorch/pytorch#35615
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#35615 Python 2 has reached end-of-life and is no longer supported by PyTorch. Now we can clean up a lot of cruft that we put in place to support it. These changes were all done manually, and I skipped anything that seemed like it would take more than a few seconds, so I think it makes sense to review it manually as well (though using side-by-side view and ignoring whitespace change might be helpful). Test Plan: CI Differential Revision: D20842886 Pulled By: dreiss fbshipit-source-id: 8cad4e87c45895e7ce3938a88e61157a79504aed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Now we can clean up a lot of cruft that we put in place to support it.
These changes were all done manually, and I skipped anything that seemed
like it would take more than a few seconds, so I think it makes sense to
review it manually as well (though using side-by-side view and ignoring
whitespace change might be helpful).
Test Plan:
CI
Differential Revision: D20842886