Remove __future__ imports from many files by dreiss · Pull Request #35627 · pytorch/pytorch

dreiss · 2020-03-28T20:47:42Z

Stack from ghstack:

Remove __future__ imports from many files #35627 Remove future imports from many files
Remove _reset_warning_registry #38485 Remove _reset_warning_registry
Remove structseq_slice #35625 Remove structseq_slice
Remove (most) Python 2 support from C++ code #35614 Remove (most) Python 2 support from C++ code

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
These future imports are already implied in Python 3.

Test Plan:
CI

Differential Revision: D20842871

Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. These future imports are already implied in Python 3. Test Plan: CI ghstack-source-id: 719ae88 Pull Request resolved: #35627

dr-ci · 2020-03-28T20:48:44Z

💊 CI failures summary and remediations

As of commit a03dbbf (more details on the Dr. CI page):

8/9 failures possibly* introduced in this PR
- 1/8 non-CircleCI failure(s)
1/9 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

🕵️ 7 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_windows_vs2019_py36_cpu_test2 (1/7)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_overrides failed!

  File "C:\Users\circleci\project\build\win_tmp\build\torch\_overrides.py", line 817, in get_overridable_functions 
    if func in get_ignored_functions(): 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\_overrides.py", line 127, in get_ignored_functions 
    torch.nn.functional.division, 
AttributeError: module 'torch.nn.functional' has no attribute 'division' 
Traceback (most recent call last): 
  File "run_test.py", line 688, in <module> 
    main() 
  File "run_test.py", line 681, in main 
    raise RuntimeError(message) 
RuntimeError: test_overrides failed! 
 
(base) circleci@PACKER-5E9D8C4B C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

pytorch_linux_bionic_py3_6_clang9_test (2/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 14 17:40:48 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" }

May 14 17:40:48     raise RuntimeError(message) 
May 14 17:40:48 RuntimeError: test_overrides failed! 
May 14 17:40:48  
May 14 17:40:48 real	21m26.608s 
May 14 17:40:48 user	24m46.559s 
May 14 17:40:48 sys	2m8.171s 
May 14 17:40:48 + cleanup 
May 14 17:40:48 + retcode=1 
May 14 17:40:48 + set +x 
May 14 17:40:48 =================== sccache compilation log =================== 
May 14 17:40:48 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
May 14 17:40:48  
May 14 17:40:48 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 14 17:40:48 Compile requests                 68 
May 14 17:40:48 Compile requests executed        35 
May 14 17:40:48 Cache hits                       27 
May 14 17:40:48 Cache misses                      7 
May 14 17:40:48 Cache timeouts                    0 
May 14 17:40:48 Cache read errors                 0 
May 14 17:40:48 Forced recaches                   0 
May 14 17:40:48 Cache write errors                0

pytorch_linux_xenial_py3_6_gcc5_4_test (3/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 14 17:42:00 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" }

May 14 17:41:59 Traceback (most recent call last): 
May 14 17:41:59   File "test/run_test.py", line 688, in <module> 
May 14 17:41:59     main() 
May 14 17:41:59   File "test/run_test.py", line 681, in main 
May 14 17:41:59     raise RuntimeError(message) 
May 14 17:41:59 RuntimeError: test_overrides failed! 
May 14 17:42:00 =================== sccache compilation log =================== 
May 14 17:42:00 + cleanup 
May 14 17:42:00 + retcode=1 
May 14 17:42:00 + set +x 
May 14 17:42:00 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
May 14 17:42:00  
May 14 17:42:00 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 14 17:42:00 Compile requests                 68 
May 14 17:42:00 Compile requests executed        35 
May 14 17:42:00 Cache hits                       27 
May 14 17:42:00 Cache misses                      7 
May 14 17:42:00 Cache timeouts                    0 
May 14 17:42:00 Cache read errors                 0 
May 14 17:42:00 Forced recaches                   0 
May 14 17:42:00 Cache write errors                0

pytorch_windows_vs2019_py36_cuda10.1_on_cpu_test2 (4/7)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_overrides failed!

  File "C:\Users\circleci\project\build\win_tmp\build\torch\_overrides.py", line 817, in get_overridable_functions 
    if func in get_ignored_functions(): 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\_overrides.py", line 127, in get_ignored_functions 
    torch.nn.functional.division, 
AttributeError: module 'torch.nn.functional' has no attribute 'division' 
Traceback (most recent call last): 
  File "run_test.py", line 688, in <module> 
    main() 
  File "run_test.py", line 681, in main 
    raise RuntimeError(message) 
RuntimeError: test_overrides failed! 
 
(base) circleci@PACKER-5E9D8C4B C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

pytorch_macos_10_13_py3_test (5/7)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

May 14 10:53:59 RuntimeError: test_overrides failed!

May 14 10:53:59   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/_overrides.py", line 817, in get_overridable_functions 
May 14 10:53:59     if func in get_ignored_functions(): 
May 14 10:53:59   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/_overrides.py", line 127, in get_ignored_functions 
May 14 10:53:59     torch.nn.functional.division, 
May 14 10:53:59 AttributeError: module 'torch.nn.functional' has no attribute 'division' 
May 14 10:53:59 Traceback (most recent call last): 
May 14 10:53:59   File "test/run_test.py", line 688, in <module> 
May 14 10:53:59     main() 
May 14 10:53:59   File "test/run_test.py", line 681, in main 
May 14 10:53:59     raise RuntimeError(message) 
May 14 10:53:59 RuntimeError: test_overrides failed! 
May 14 10:53:59 + cleanup 
May 14 10:53:59 + retcode=1 
May 14 10:53:59 + set +x

pytorch_windows_vs2019_py36_cuda10.1_test2 (6/7)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_overrides failed!

  File "C:\Users\circleci\project\build\win_tmp\build\torch\_overrides.py", line 817, in get_overridable_functions 
    if func in get_ignored_functions(): 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\_overrides.py", line 127, in get_ignored_functions 
    torch.nn.functional.division, 
AttributeError: module 'torch.nn.functional' has no attribute 'division' 
Traceback (most recent call last): 
  File "run_test.py", line 688, in <module> 
    main() 
  File "run_test.py", line 681, in main 
    raise RuntimeError(message) 
RuntimeError: test_overrides failed! 
 
(base) circleci@PACKER-5E9E037A C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

pytorch_linux_xenial_py3_clang5_asan_test (7/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 14 17:29:55 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in

May 14 17:29:54     #7 0x55cd40df474b in PyEval_EvalCode /tmp/build/80754af9/python_1585002248360/work/Python/ceval.c:731 
May 14 17:29:54     #8 0x55cd40e74633 in run_mod /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:1025 
May 14 17:29:54     #9 0x55cd40e746cc in PyRun_StringFlags /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:949 
May 14 17:29:54     #10 0x55cd40e7472e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:445 
May 14 17:29:54     #11 0x55cd40e78532 in run_command /tmp/build/80754af9/python_1585002248360/work/Modules/main.c:301 
May 14 17:29:54     #12 0x55cd40e78532 in Py_Main /tmp/build/80754af9/python_1585002248360/work/Modules/main.c:749 
May 14 17:29:54     #13 0x55cd40d431fd in main /tmp/build/80754af9/python_1585002248360/work/Programs/python.c:69 
May 14 17:29:55     #14 0x7f153626882f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291 
May 14 17:29:55     #15 0x55cd40e21c29 in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103 
May 14 17:29:55  
May 14 17:29:55 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in  
May 14 17:29:55 + retcode=1 
May 14 17:29:55 + set -e 
May 14 17:29:55 + return 1 
May 14 17:29:55 + [[ pytorch-linux-xenial-py3-clang5-asan-test == *-NO_AVX-* ]] 
May 14 17:29:55 + [[ pytorch-linux-xenial-py3-clang5-asan-test == *-NO_AVX2-* ]] 
May 14 17:29:55 + '[' -n https://github.com/pytorch/pytorch/pull/35627 ']' 
May 14 17:29:55 ++ mktemp 
May 14 17:29:55 + DETERMINE_FROM=/tmp/tmp.fTapB4z0w8 
May 14 17:29:55 + file_diff_from_base /tmp/tmp.fTapB4z0w8 
May 14 17:29:55 + set +e

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

May 14 18:02:52 ConnectionResetError: [Errno 104] Connection reset by peer

May 14 18:02:52   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 493, in Client 
May 14 18:02:52     answer_challenge(c, authkey) 
May 14 18:02:52   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 737, in answer_challenge 
May 14 18:02:52     response = connection.recv_bytes(256)        # reject large message 
May 14 18:02:52   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes 
May 14 18:02:52     buf = self._recv_bytes(maxlength) 
May 14 18:02:52   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes 
May 14 18:02:52     buf = self._recv(4) 
May 14 18:02:52   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 379, in _recv 
May 14 18:02:52     chunk = read(handle, remaining) 
May 14 18:02:52 ConnectionResetError: [Errno 104] Connection reset by peer 
May 14 18:02:52  
May 14 18:02:52 Process ErrorTrackingProcess-120: 
May 14 18:02:52 Traceback (most recent call last): 
May 14 18:02:52   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap 
May 14 18:02:52     self.run() 
May 14 18:02:52   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 362, in run 
May 14 18:02:52     super(ErrorTrackingProcess, self).run() 
May 14 18:02:52   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 93, in run 
May 14 18:02:52     self._target(*self._args, **self._kwargs) 
May 14 18:02:52   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 630, in _test_proper_exit

ci.pytorch.org: 1 failed

Failed: pr/py3.6-clang7-rocmdeb-ubuntu16.04

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 76 times.

Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. These future imports are already implied in Python 3. Test Plan: CI ghstack-source-id: 8d83e9e Pull Request resolved: #35627

Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. These future imports are already implied in Python 3. Test Plan: CI Differential Revision: [D20842871](https://our.internmc.facebook.com/intern/diff/D20842871)

Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. These future imports are already implied in Python 3. Test Plan: CI ghstack-source-id: c5ee470 Pull Request resolved: #35627

dreiss · 2020-05-20T14:58:09Z

Reopened as #38778 due to ghstack shenanigans.

dreiss requested review from apaszke, ezyang, fmassa, goldsborough, mrshenli, pietern, pritamdamania87, soumith and zhaojuanmao as code owners March 28, 2020 20:47

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 28, 2020

ezyang approved these changes Mar 30, 2020

View reviewed changes

dreiss added 2 commits May 13, 2020 20:50

dreiss mentioned this pull request May 14, 2020

Remove _reset_warning_registry #38485

Closed

dreiss closed this May 20, 2020

dreiss mentioned this pull request May 20, 2020

Remove __future__ imports from many files #38778

Closed

facebook-github-bot deleted the gh/dreiss/44/head branch June 20, 2020 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove future imports from many files#35627

Remove future imports from many files#35627
dreiss wants to merge 2 commits intogh/dreiss/44/basefrom
gh/dreiss/44/head

dreiss commented Mar 28, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented Mar 28, 2020 •

edited

Loading

Uh oh!

dreiss commented May 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dreiss commented Mar 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Mar 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 7 new failures recognized by patterns

pytorch_windows_vs2019_py36_cpu_test2 (1/7)

pytorch_linux_bionic_py3_6_clang9_test (2/7)

pytorch_linux_xenial_py3_6_gcc5_4_test (3/7)

pytorch_windows_vs2019_py36_cuda10.1_on_cpu_test2 (4/7)

pytorch_macos_10_13_py3_test (5/7)

pytorch_windows_vs2019_py36_cuda10.1_test2 (6/7)

pytorch_linux_xenial_py3_clang5_asan_test (7/7)

❄️ 1 failure tentatively classified as flaky

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (1/1)

ci.pytorch.org: 1 failed

Uh oh!

dreiss commented May 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dreiss commented Mar 28, 2020 •

edited

Loading

dr-ci Bot commented Mar 28, 2020 •

edited

Loading