Skip to content

Remove structseq_slice#35625

Closed
dreiss wants to merge 8 commits intogh/dreiss/42/basefrom
gh/dreiss/42/head
Closed

Remove structseq_slice#35625
dreiss wants to merge 8 commits intogh/dreiss/42/basefrom
gh/dreiss/42/head

Conversation

@dreiss
Copy link
Copy Markdown
Contributor

@dreiss dreiss commented Mar 28, 2020

Stack from ghstack:

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: D20842885

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 28, 2020

💊 CI failures summary and remediations

As of commit 2c3f4ba (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 47 times.

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)
dreiss added a commit that referenced this pull request Apr 15, 2020
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

ghstack-source-id: 2ad110f
Pull Request resolved: #35625
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)
dreiss added a commit that referenced this pull request Apr 17, 2020
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

ghstack-source-id: 03ee51c
Pull Request resolved: #35625
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)

[ghstack-poisoned]
dreiss added a commit that referenced this pull request Apr 17, 2020
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

ghstack-source-id: 938c102
Pull Request resolved: #35625
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)

[ghstack-poisoned]
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)

[ghstack-poisoned]
dreiss added a commit that referenced this pull request Apr 22, 2020
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

ghstack-source-id: ee965d1
Pull Request resolved: #35625
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)
dreiss added 2 commits May 13, 2020 20:50
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan:
CI

Differential Revision: [D20842885](https://our.internmc.facebook.com/intern/diff/D20842885)
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@dreiss merged this pull request in b140ed6.

@facebook-github-bot facebook-github-bot deleted the gh/dreiss/42/head branch May 18, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#35625

Python 2 has reached end-of-life and is no longer supported by PyTorch.
This function was already ifdef'ed out in Python 2.

Added a comment about when we might be able to remove this entire file.

Test Plan: CI

Differential Revision: D20842885

Pulled By: dreiss

fbshipit-source-id: 1fd3b1b2ff5a82caaf3bc11344dde2941427cfc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants