Skip to content

Remove _compatible_subtest#35620

Closed
dreiss wants to merge 9 commits intogh/dreiss/37/basefrom
gh/dreiss/37/head
Closed

Remove _compatible_subtest#35620
dreiss wants to merge 9 commits intogh/dreiss/37/basefrom
gh/dreiss/37/head

Conversation

@dreiss
Copy link
Copy Markdown
Contributor

@dreiss dreiss commented Mar 28, 2020

Stack from ghstack:

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
self.subTest can be used directly in Python 3.

Test Plan:
CI

Differential Revision: D20842872

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 28, 2020

💊 CI failures summary and remediations

As of commit 533da52 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 46 times.

dreiss added 6 commits April 3, 2020 09:08
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)

[ghstack-poisoned]
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)

[ghstack-poisoned]
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)

[ghstack-poisoned]
okly366 pushed a commit to okly366/pytorch that referenced this pull request Apr 26, 2020
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

ghstack-source-id: d7eb575
Pull Request resolved: pytorch/pytorch#35620
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
@dreiss dreiss requested a review from soumith May 13, 2020 18:33
@dreiss
Copy link
Copy Markdown
Contributor Author

dreiss commented May 13, 2020

Not sure why I can't request review from @mickypaganini .

Copy link
Copy Markdown
Collaborator

@soumith soumith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@dreiss merged this pull request in d060deb.

@facebook-github-bot facebook-github-bot deleted the gh/dreiss/37/head branch May 18, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#35620

Python 2 has reached end-of-life and is no longer supported by PyTorch.
`self.subTest` can be used directly in Python 3.

Test Plan: CI

Differential Revision: D20842872

Pulled By: dreiss

fbshipit-source-id: 6ad42550c01e6959821ff07df767fc14b58c5a9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants