Remove _compatible_subtest#35620
Closed
dreiss wants to merge 9 commits intogh/dreiss/37/basefrom
Closed
Conversation
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI
This was referenced Mar 28, 2020
💊 CI failures summary and remediationsAs of commit 533da52 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 46 times. |
This was referenced Mar 28, 2020
Closed
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872) [ghstack-poisoned]
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872) [ghstack-poisoned]
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872) [ghstack-poisoned]
okly366
pushed a commit
to okly366/pytorch
that referenced
this pull request
Apr 26, 2020
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI ghstack-source-id: d7eb575 Pull Request resolved: pytorch/pytorch#35620
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
Contributor
Author
|
Not sure why I can't request review from @mickypaganini . |
Summary: Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: [D20842872](https://our.internmc.facebook.com/intern/diff/D20842872)
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#35620 Python 2 has reached end-of-life and is no longer supported by PyTorch. `self.subTest` can be used directly in Python 3. Test Plan: CI Differential Revision: D20842872 Pulled By: dreiss fbshipit-source-id: 6ad42550c01e6959821ff07df767fc14b58c5a9e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
self.subTestcan be used directly in Python 3.Test Plan:
CI
Differential Revision: D20842872