Skip to content

Remove _uses_true_division#35618

Closed
dreiss wants to merge 9 commits intogh/dreiss/35/basefrom
gh/dreiss/35/head
Closed

Remove _uses_true_division#35618
dreiss wants to merge 9 commits intogh/dreiss/35/basefrom
gh/dreiss/35/head

Conversation

@dreiss
Copy link
Copy Markdown
Contributor

@dreiss dreiss commented Mar 28, 2020

Stack from ghstack:

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: D20842884

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 28, 2020

💊 CI failures summary and remediations

As of commit 8f8a783 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 52 times.

Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped.

dreiss added 6 commits April 3, 2020 09:08
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: [D20842884](https://our.internmc.facebook.com/intern/diff/D20842884)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: [D20842884](https://our.internmc.facebook.com/intern/diff/D20842884)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: [D20842884](https://our.internmc.facebook.com/intern/diff/D20842884)

[ghstack-poisoned]
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: [D20842884](https://our.internmc.facebook.com/intern/diff/D20842884)

[ghstack-poisoned]
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: [D20842884](https://our.internmc.facebook.com/intern/diff/D20842884)

[ghstack-poisoned]
okly366 pushed a commit to okly366/pytorch that referenced this pull request Apr 26, 2020
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

ghstack-source-id: e2f550f
Pull Request resolved: pytorch/pytorch#35618
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: [D20842884](https://our.internmc.facebook.com/intern/diff/D20842884)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan:
CI

Differential Revision: [D20842884](https://our.internmc.facebook.com/intern/diff/D20842884)
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@dreiss merged this pull request in 7026b39.

@facebook-github-bot facebook-github-bot deleted the gh/dreiss/35/head branch May 18, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#35618

Python 2 has reached end-of-life and is no longer supported by PyTorch.
Python 3 always uses true division.

Test Plan: CI

Differential Revision: D20842884

Pulled By: dreiss

fbshipit-source-id: 522e34bb584d4bdb01c9c40eb267955062a57774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants