refactor tryMatchSchema (#26499)#27773
Closed
zdevito wants to merge 3 commits intogh/zdevito/125/basefrom
Closed
Conversation
We've changed how these functions are used over time, so I cleaned up the header file API to match. In particular: * tryMatchSchemas was added since the overload logic got copy/pasted into three separate locations. * With this change, tryMatchSchema is no longer public, as it is not needed outside of tryMatchSchemas * emitBuiltinFunction no longer needs a requires argument (it was always true) * Argument order for all the schema matching stuff now puts the 'self' builtin override last. This is only rarely used and was inconsistent with matchSchema
This was referenced Oct 11, 2019
refactor tryMatchSchema (#26499) We've changed how these functions are used over time, so I cleaned up the header file API to match. In particular: * tryMatchSchemas was added since the overload logic got copy/pasted into three separate locations. * With this change, tryMatchSchema is no longer public, as it is not needed outside of tryMatchSchemas * emitBuiltinFunction no longer needs a requires argument (it was always true) * Argument order for all the schema matching stuff now puts the 'self' builtin override last. This is only rarely used and was inconsistent with matchSchema gh-metadata: pytorch pytorch 27773 gh/zdevito/125/head
wanchaol
approved these changes
Oct 11, 2019
refactor tryMatchSchema (#26499) We've changed how these functions are used over time, so I cleaned up the header file API to match. In particular: * tryMatchSchemas was added since the overload logic got copy/pasted into three separate locations. * With this change, tryMatchSchema is no longer public, as it is not needed outside of tryMatchSchemas * emitBuiltinFunction no longer needs a requires argument (it was always true) * Argument order for all the schema matching stuff now puts the 'self' builtin override last. This is only rarely used and was inconsistent with matchSchema gh-metadata: pytorch pytorch 27773 gh/zdevito/125/head
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#27773 We've changed how these functions are used over time, so I cleaned up the header file API to match. In particular: * tryMatchSchemas was added since the overload logic got copy/pasted into three separate locations. * With this change, tryMatchSchema is no longer public, as it is not needed outside of tryMatchSchemas * emitBuiltinFunction no longer needs a requires argument (it was always true) * Argument order for all the schema matching stuff now puts the 'self' builtin override last. This is only rarely used and was inconsistent with matchSchema Test Plan: Imported from OSS Differential Revision: D17885425 Pulled By: zdevito fbshipit-source-id: 064bc9fa4bd57b2e5366fff9f3c6ab9b9945e08b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We've changed how these functions are used over time, so I cleaned up
the header file API to match. In particular:
tryMatchSchemas was added since the overload logic got copy/pasted
into three separate locations.
With this change, tryMatchSchema is no longer public, as it is not needed
outside of tryMatchSchemas
emitBuiltinFunction no longer needs a requires argument (it was always true)
Argument order for all the schema matching stuff now puts the 'self'
builtin override last. This is only rarely used and was inconsistent with
matchSchema
Differential Revision: D17885425