[jit] Allow 'Any' to appear as a type argument.#26572
Closed
zdevito wants to merge 5 commits intogh/zdevito/113/basefrom
Closed
[jit] Allow 'Any' to appear as a type argument.#26572zdevito wants to merge 5 commits intogh/zdevito/113/basefrom
zdevito wants to merge 5 commits intogh/zdevito/113/basefrom
Conversation
This was referenced Sep 20, 2019
suo
approved these changes
Oct 9, 2019
| self.assertEqual(any_refinement(3, 4), 7) | ||
| self.assertEqual(any_refinement(3, "hi"), 0) | ||
|
|
||
| def test_any_in_class_fails(self): |
Member
There was a problem hiding this comment.
Can we add tests that verify that Any is not allowed in Tuples, NamedTuples, or Interfaces as well?
| // static types in named types to reconstruct type tags of loaded | ||
| // values. Lifting this restriction requires solving the serialization | ||
| // problem first. | ||
| CAFFE2_API void checkNoAny( |
Member
There was a problem hiding this comment.
I am a little wary of having this enforcement as opt-in. For example, if someone goes in and adds attributes to interfaces and forgets to include this check, we've very quickly produced the bug this comment describes.
Contributor
Author
There was a problem hiding this comment.
The specific example of interfaces will not actually cause this bug, but I agree in spirit. But how would we make it more likely to be called? There isn't a more common place to put it.
This was referenced Oct 11, 2019
[jit] Allow 'Any' to appear as a type argument. Combined with isinstance specialization this allows a degree of polymorphic functions to work without needing to use our weirder overload hacks. We do not define any operators on Any, so the only thing you can do with it is to put it in containers or type refine it using an isinstance check. Any is restricted from appearing in non-argument position because we cannot restore type tags if it ends up as a field in a class. gh-metadata: pytorch pytorch 26572 gh/zdevito/113/head
[jit] Allow 'Any' to appear as a type argument. Combined with isinstance specialization this allows a degree of polymorphic functions to work without needing to use our weirder overload hacks. We do not define any operators on Any, so the only thing you can do with it is to put it in containers or type refine it using an isinstance check. Any is restricted from appearing in non-argument position because we cannot restore type tags if it ends up as a field in a class. gh-metadata: pytorch pytorch 26572 gh/zdevito/113/head
[jit] Allow 'Any' to appear as a type argument. Combined with isinstance specialization this allows a degree of polymorphic functions to work without needing to use our weirder overload hacks. We do not define any operators on Any, so the only thing you can do with it is to put it in containers or type refine it using an isinstance check. Any is restricted from appearing in non-argument position because we cannot restore type tags if it ends up as a field in a class. gh-metadata: pytorch pytorch 26572 gh/zdevito/113/head
[jit] Allow 'Any' to appear as a type argument. Combined with isinstance specialization this allows a degree of polymorphic functions to work without needing to use our weirder overload hacks. We do not define any operators on Any, so the only thing you can do with it is to put it in containers or type refine it using an isinstance check. Any is restricted from appearing in non-argument position because we cannot restore type tags if it ends up as a field in a class. gh-metadata: pytorch pytorch 26572 gh/zdevito/113/head
[jit] Allow 'Any' to appear as a type argument. Combined with isinstance specialization this allows a degree of polymorphic functions to work without needing to use our weirder overload hacks. We do not define any operators on Any, so the only thing you can do with it is to put it in containers or type refine it using an isinstance check. Any is restricted from appearing in non-argument position because we cannot restore type tags if it ends up as a field in a class. gh-metadata: pytorch pytorch 26572 gh/zdevito/113/head
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
Oct 16, 2019
Summary: Pull Request resolved: pytorch/pytorch#26572 Combined with isinstance specialization this allows a degree of polymorphic functions to work without needing to use our weirder overload hacks. We do not define any operators on Any, so the only thing you can do with it is to put it in containers or type refine it using an isinstance check. Any is restricted from appearing in non-argument position because we cannot restore type tags if it ends up as a field in a class. Test Plan: Imported from OSS Differential Revision: D17530643 Pulled By: zdevito fbshipit-source-id: f06f78ce84819f7773953a492f3d4c49219ee94c
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26572 Combined with isinstance specialization this allows a degree of polymorphic functions to work without needing to use our weirder overload hacks. We do not define any operators on Any, so the only thing you can do with it is to put it in containers or type refine it using an isinstance check. Any is restricted from appearing in non-argument position because we cannot restore type tags if it ends up as a field in a class. Test Plan: Imported from OSS Differential Revision: D17530643 Pulled By: zdevito fbshipit-source-id: f06f78ce84819f7773953a492f3d4c49219ee94c
tangleintel
reviewed
Jun 27, 2022
| inline Stack toTraceableStack(const py::tuple& inputs) { | ||
| auto info = toTypeInferredIValue(inputs); | ||
| AT_CHECK( | ||
| isTraceableType(info.type()), |
Contributor
There was a problem hiding this comment.
Hi, @zdevito
May I know why we only support Tensors and (possibly nested) Lists, Dicts, and Tuples of Tensors?
What if we passed a None type of python, and what will happen that makes us not support it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Combined with isinstance specialization this allows a degree of polymorphic
functions to work without needing to use our weirder overload hacks.
We do not define any operators on Any, so the only thing you can do with it
is to put it in containers or type refine it using an isinstance check.
Any is restricted from appearing in non-argument position because we
cannot restore type tags if it ends up as a field in a class.
Differential Revision: D17530643