[jit] Remove attempToRecoverType#26767
Closed
zdevito wants to merge 3 commits intogh/zdevito/115/basefrom
Closed
Conversation
This was referenced Sep 24, 2019
suo
approved these changes
Sep 25, 2019
This was referenced Oct 8, 2019
[jit] Remove attempToRecoverType Now that we have tagged ivalues, we can accurately recover the type with `ivalue.type()`. This reomoves the other half-implemented pathways that were created because we didn't have tags. gh-metadata: pytorch pytorch 26767 gh/zdevito/115/head
[jit] Remove attempToRecoverType Now that we have tagged ivalues, we can accurately recover the type with `ivalue.type()`. This reomoves the other half-implemented pathways that were created because we didn't have tags. gh-metadata: pytorch pytorch 26767 gh/zdevito/115/head
[jit] Remove attempToRecoverType Now that we have tagged ivalues, we can accurately recover the type with `ivalue.type()`. This reomoves the other half-implemented pathways that were created because we didn't have tags. gh-metadata: pytorch pytorch 26767 gh/zdevito/115/head
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
Oct 16, 2019
Summary: Pull Request resolved: pytorch/pytorch#26767 Now that we have tagged ivalues, we can accurately recover the type with `ivalue.type()`. This reomoves the other half-implemented pathways that were created because we didn't have tags. Test Plan: Imported from OSS Differential Revision: D17561191 Pulled By: zdevito fbshipit-source-id: 26aaa134099e75659a230d8a5a34a86dc39a3c5c
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26767 Now that we have tagged ivalues, we can accurately recover the type with `ivalue.type()`. This reomoves the other half-implemented pathways that were created because we didn't have tags. Test Plan: Imported from OSS Differential Revision: D17561191 Pulled By: zdevito fbshipit-source-id: 26aaa134099e75659a230d8a5a34a86dc39a3c5c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Now that we have tagged ivalues, we can accurately recover the type with
ivalue.type(). This reomoves the other half-implemented pathways thatwere created because we didn't have tags.
Differential Revision: D17561191