[jit] Make PythonPrint a class#26787
Closed
zdevito wants to merge 20 commits intogh/zdevito/117/basefrom
Closed
Conversation
A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch.
This was referenced Sep 25, 2019
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
This was referenced Oct 11, 2019
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
[jit] Make PythonPrint a class A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. gh-metadata: pytorch pytorch 26787 gh/zdevito/117/head
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26787 A follow up PR will remove the need to issue import statements, or write classes in order since they are no longer needed. This change allows the same PythonPrint class to be used for an entire file which will be needed in that patch. Test Plan: Imported from OSS Differential Revision: D17566440 Pulled By: zdevito fbshipit-source-id: 1ee896da0cdfe6a003298e1d4b0238403b9ed6dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
A follow up PR will remove the need to issue import statements,
or write classes in order since they are no longer needed.
This change allows the same PythonPrint class
to be used for an entire file which will be needed in that patch.
Differential Revision: D17566440